Fix regression where non-raid attached disks did not determine correct disk type#133
Merged
hallyn merged 2 commits intoproject-machine:mainfrom Feb 22, 2024
Merged
Conversation
Add coverage for the diskType hint under kvm Signed-off-by: Ryan Harper <ryaharpe@cisco.com>
…t disk type The raid controller merge regressed the path for non-raid attached disks and all such disks were classified as HDDs. This was found under KVM testing where disko uses a prefix in the ID_SERIAL property to set the disk type to SSD. Signed-off-by: Ryan Harper <ryaharpe@cisco.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #133 +/- ##
==========================================
+ Coverage 65.38% 66.02% +0.64%
==========================================
Files 17 17
Lines 2551 2555 +4
==========================================
+ Hits 1668 1687 +19
+ Misses 683 661 -22
- Partials 200 207 +7 ☔ View full report in Codecov by Sentry. |
hallyn
approved these changes
Feb 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The raid controller merge regressed the path for non-raid attached disks
and all such disks were classified as HDDs. This was found under KVM
testing where disko uses a prefix in the ID_SERIAL property to set the
disk type to SSD.