fix: don't mix up runtimedir and metadir #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
==========================================
+ Coverage 38.50% 38.59% +0.08%
==========================================
Files 24 24
Lines 2254 2257 +3
==========================================
+ Hits 868 871 +3
Misses 1208 1208
Partials 178 178 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tych0
approved these changes
Jul 16, 2025
hallyn
force-pushed
the
2025-07-13/runtimedir
branch
from
ab19c16 to
ed53331
Compare
The runtimedir is e.g. /run/atomfs The metadir is e.g. /run/atomfs/meta/NSNAME/encoded-path The RuntimeDir() fn would return runtimedir in most cases, but in one case, it would return the passed-in metapath. As a result, it could happen that mount, umount, mount of the same path would fail the final mount, because it saw that runtimedir existed, when it should only care if metadir exists. Signed-off-by: Serge Hallyn <serge@hallyn.com>
hallyn
force-pushed
the
2025-07-13/runtimedir
branch
from
ed53331 to
b754628
Compare
mikemccracken
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The runtimedir is e.g. /run/atomfs
The metadir is e.g. /run/atomfs/meta/NSNAME/encoded-path
The RuntimeDir() fn would return runtimedir in most cases, but in one case, it would return the passed-in metapath.
As a result, it could happen that mount, umount, mount of the same path would fail the final mount, because it saw that runtimedir existed, when it should only care if metadir exists.