ci: enable golangci-lint #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
=======================================
Coverage 38.71% 38.71%
=======================================
Files 24 24
Lines 2255 2255
=======================================
Hits 873 873
Misses 1207 1207
Partials 175 175 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Ramkumar Chinchani <rchincha.dev@gmail.com>
raharper
reviewed
Mar 28, 2025
|
|
||
| # Optional: golangci-lint command line arguments. | ||
| # args: --issues-exit-code=0 | ||
| args: --config ./golangcilint.yaml --exclude-files ./pkg/verity/verity.go --enable-all ./cmd/... ./pkg/... |
There was a problem hiding this comment.
Could you comment on excluding verity.go ?
There was a problem hiding this comment.
Ah, I see below related to cgo ... can we add that comment to the lint.yaml so we remember why?
| timeout: 60m | ||
|
|
||
| linters: | ||
| enable-all: true |
There was a problem hiding this comment.
How do you feel about not tweaking these? While I don't some of the defaults, it might be easier than keeping a list of what we don't want?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.