Skip to content

RHCLOUD-45844: updates renovate schedule and go pkg management#853

Merged
tonytheleg merged 1 commit intoproject-kessel:mainfrom
tonytheleg:minor-renovate-update
Mar 24, 2026
Merged

RHCLOUD-45844: updates renovate schedule and go pkg management#853
tonytheleg merged 1 commit intoproject-kessel:mainfrom
tonytheleg:minor-renovate-update

Conversation

@tonytheleg
Copy link
Copy Markdown
Contributor

@tonytheleg tonytheleg commented Mar 24, 2026

PR Template:

Describe your changes

Minor updates to our renovate config to improve Konflux PR's

  • Updates the schedule to increase the time window and ensure ample time for Mintmaker to create PRs
    • New schedule per recommendation from Konflux team
  • Adds config to group all go pkg related updates into a single PR to reduce the number of PR's and rebase's required to merge
    • Also recommended by Konflux team, See provided example that my changes were based off of

Validation

$ npx --yes renovate-config-validator
INFO: Validating .github/renovate.json
INFO: Config validated successfully

Summary by CodeRabbit

  • Chores
    • Updated dependency management configuration to enhance how Go module and Docker image updates are scheduled and organized. Go module updates are now grouped together for improved visibility and management. Update scheduling has been adjusted for both dependency types to provide more frequent and organized update notifications.

@app-sre-bot
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 24, 2026

📝 Walkthrough

Walkthrough

Reorganized Renovate configuration to separate dockerfile and gomod package management rules into distinct top-level objects. Updated schedules for both and added Go-specific grouping configuration with custom branch and commit message topic prefixes.

Changes

Cohort / File(s) Summary
Renovate Configuration
.github/renovate.json
Restructured packageRules into separate dockerfile and gomod configurations. Expanded schedules from * 0-1 * * 0 to * 0-7 * * 0. Added nested packageRules with matchDatasources: ["go"] and grouping configuration (groupName: "Go updates", custom branchTopic/commitMessageTopic).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description covers the key changes and includes validation, but is missing most required template sections like ticket reference, acceptance criteria checklist, and deployment verification. Complete the PR template by adding ticket reference (Fixes #), filling out acceptance criteria checklist items, and documenting deployment status when applicable.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main changes: updating the Renovate schedule and configuring Go package management grouping.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/renovate.json:
- Around line 6-19: Remove the invalid nested "group" object inside the
"packageRules" entry and move "branchTopic" and "commitMessageTopic" up as
direct properties of that package rule: update the "gomod" -> "packageRules"
rule that currently has "matchDatasources": ["go"] so that "branchTopic" and
"commitMessageTopic" are sibling properties of "matchDatasources" and "enabled",
and delete the "group" wrapper entirely.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d5fe0359-2ac8-4b12-bc75-f54ebbf80bfc

📥 Commits

Reviewing files that changed from the base of the PR and between 0ac5460 and f25fe3e.

📒 Files selected for processing (1)
  • .github/renovate.json

Copy link
Copy Markdown
Member

@tylercreller tylercreller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonytheleg tonytheleg merged commit 1e77c75 into project-kessel:main Mar 24, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants