Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin to pip 18.1 #447

Merged
merged 1 commit into from
Jan 28, 2019
Merged

Pin to pip 18.1 #447

merged 1 commit into from
Jan 28, 2019

Conversation

rbreslow
Copy link
Contributor

Overview

Between Jenkins builds #120 and #121, pip 19.0 was released (https://pypi.org/project/pip/#history).

We weren't pinning to a specific version of pip in the Packer shell provisioner, so builds started using pip 19.0, and builds started failing.

Fixes #441

Testing Instructions

See successful CI build: http://civicci01.internal.azavea.com/job/bee-pollinator-app-and-worker/129/

Copy link
Contributor

@hectcastro hectcastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to include a little detail about why we weren't able to work with pip 19 in the commit message. We don't know all of the details, but some explanation would be helpful for the person (possibly us) down the road who sees the pip version constraint and wants to update it.

When pip 19.0 was released, builds started failing with messages similar to Cannot uninstall 'requests'. It is a distutils installed project and thus we cannot accurately determine which files belong to it which would lead to only a partial uninstall. When we stopped installing the python-requests-whl package, this error would move to another package, like urllib3. In the end, it seemed that pinning the pip version to 18.1 prevented these errors from happening.
@rbreslow rbreslow merged commit 15bec3e into develop Jan 28, 2019
@rbreslow rbreslow deleted the feature/jrb/fix-ami-builds branch January 28, 2019 21:25
rajadain added a commit to WikiWatershed/model-my-watershed that referenced this pull request Jan 29, 2019
As of pip 19.0, it started printing warnings for Python 2.7, which
are treated as errors by Jenkins. I looked briefly in to ignoring
or silencing those warnings (see pypa/pip#6147 (comment)),
but couldn't configure Jenkins correctly. Thus, I'm going with the
downgrade, as was done for #bees in project-icp/bee-pollinator-app#447.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants