Added a container cache disk option. #149
Conversation
To improve performance, the container working directories should be moved to a different drive than the etcd and os directories. An option was added to the configuration to specify a drive to use for this purpose. This addresses #142.
|
@mulbc Would you mind reviewing this? |
| @@ -27,12 +27,26 @@ | |||
| - "{{ openshift_installer_dir }}/install-config.yaml" | |||
| - "{{ openshift_installer_dir }}/install-config.yaml.bkp" | |||
|
|
|||
| - name: create ignition files | |||
| - name: cleanup previous install artifacts | |||
| shell: > | |||
There was a problem hiding this comment.
You could consider doing this with the file module:
- name: my-state
file:
state: absent
path: {item}
with_items:
- firstDir
- secondDir
| version: 3.1.0 | ||
| storage: | ||
| disks: | ||
| - device: /dev/{{ openshift_installer_cache_disk }} |
There was a problem hiding this comment.
I would intuitively set openshift_installer_cache_disk to /dev/sdb (or whatever disk) rather than sdb - so the full path to the disk...
That's why I wouldn't prepend /dev in this template
There was a problem hiding this comment.
I almost did that, but there is another config option that asks for the disk to install the OS on. That option doesn't require a /dev prefix because the CoreOS kernel args don't allow the /dev prefix.
So I wanted to stay consistent with that.
| - device: /dev/{{ openshift_installer_cache_disk }} | ||
| wipeTable: True | ||
| partitions: | ||
| - sizeMiB: 50000 |
There was a problem hiding this comment.
Idea: use 50% of the disk size (gathered by ansible facts in ansible_devices) rather than 50GB statically?
What do you think?
There was a problem hiding this comment.
Ansible doesn't have any facts about the host at this time. This file is created before the host is created or powered on. I don't think there is a clean way to do that with ipmi/ilo either.
Changed a shell call to a file call.
To improve performance, the container working directories should be
moved to a different drive than the etcd and os directories. An option
was added to the configuration to specify a drive to use for this
purpose.
This addresses #142.