Double quotes around passwords.

project-faros · Oct 5, 2020 · 191dad9 · 191dad9
1 parent 47ff2a3
commit 191dad9
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/app/playbooks/firmware.d/el8000-sw2-ssd/apply.yml b/app/playbooks/firmware.d/el8000-sw2-ssd/apply.yml
@@ -30,7 +30,7 @@
       delegate_to: localhost
 
     - name: login to ilo
-      shell: ilorest -c "{{ config.path }}" login "{{ mgmt_hostname }}" -u "{{ username }}" -p "{{ password }}"
+      shell: ilorest -c "{{ config.path }}" login "{{ mgmt_hostname }}" -u '{{ username }}' -p '{{ password }}'
       changed_when: False
       delegate_to: localhost
 

diff --git a/app/playbooks/firmware.d/el8000-sw2-ssd/iloaccount.yml b/app/playbooks/firmware.d/el8000-sw2-ssd/iloaccount.yml
@@ -1,12 +1,12 @@
 - name: ensure service account exists
   block:
   - name: creating service account (may fail)
-    shell: ilorest -c "{{ config.path }}" iloaccounts add {{ mgmt_user }} {{ mgmt_user }} "{{ mgmt_password }}" --addprivs 1,3,6,7,8
+    shell: ilorest -c "{{ config.path }}" iloaccounts add {{ mgmt_user }} {{ mgmt_user }} '{{ mgmt_password }}' --addprivs 1,3,6,7,8
     delegate_to: localhost
 
   rescue:
   - name: modifying service account password
-    shell: ilorest -c "{{ config.path }}" iloaccounts changepass {{ mgmt_user }} "{{ mgmt_password }}"
+    shell: ilorest -c "{{ config.path }}" iloaccounts changepass {{ mgmt_user }} '{{ mgmt_password }}'
     delegate_to: localhost
 
   - name: modifying service account privs

diff --git a/app/roles/management/tasks/poweroff/ilo.yml b/app/roles/management/tasks/poweroff/ilo.yml
@@ -1,6 +1,6 @@
 - name: get ilo server power status
   shell: >
-    hpilo_cli -l "{{ management_user }}" -p "{{ management_pass }}" -j
+    hpilo_cli -l "{{ management_user }}" -p '{{ management_pass }}' -j
     "{{ management_hostname }}" get_host_power_status
   delegate_to: localhost
   become: no
@@ -9,15 +9,15 @@
 
 - name: power off ilo server power state
   shell: >
-    hpilo_cli -l "{{ management_user }}" -p "{{ management_pass }}" -y
+    hpilo_cli -l "{{ management_user }}" -p '{{ management_pass }}' -y
     "{{ management_hostname }}" hold_pwr_btn
   delegate_to: localhost
   become: no
   when: "ilo_power_status.stdout != '\"OFF\"'"
 
 - name: wait until ilo server powers off
   shell: >
-    hpilo_cli -l "{{ management_user }}" -p "{{ management_pass }}" -j
+    hpilo_cli -l "{{ management_user }}" -p '{{ management_pass }}' -j
     "{{ management_hostname }}" get_host_power_status
   delegate_to: localhost
   become: no

diff --git a/app/roles/management/tasks/poweron/ilo.yml b/app/roles/management/tasks/poweron/ilo.yml
@@ -1,6 +1,6 @@
 - name: get ilo server power status
   shell: >
-    hpilo_cli -l "{{ management_user }}" -p "{{ management_pass }}" -j
+    hpilo_cli -l "{{ management_user }}" -p '{{ management_pass }}' -j
     "{{ management_hostname }}" get_host_power_status
   delegate_to: localhost
   become: no
@@ -9,15 +9,15 @@
 
 - name: power on ilo server power state
   shell: >
-    hpilo_cli -l "{{ management_user }}" -p "{{ management_pass }}" -y
+    hpilo_cli -l "{{ management_user }}" -p '{{ management_pass }}' -y
     "{{ management_hostname }}" press_pwr_btn
   delegate_to: localhost
   become: no
   when: "ilo_power_status.stdout != '\"ON\"'"
 
 - name: wait until ilo server powers on
   shell: >
-    hpilo_cli -l "{{ management_user }}" -p "{{ management_pass }}" -j
+    hpilo_cli -l "{{ management_user }}" -p '{{ management_pass }}' -j
     "{{ management_hostname }}" get_host_power_status
   delegate_to: localhost
   become: no