Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update storytxt.cfg #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update storytxt.cfg #10

wants to merge 1 commit into from

Conversation

pkaction
Copy link

@pkaction pkaction commented Nov 6, 2015

A lot of English editing. I tried to simplify the language. Use the active voice, less passive. I tried to make the verb tenses more consistent. I tried to strip out a lot of unnecessary words. Hope that helps.

A lot of English editing.  I tried to simplify the language.  Use the active voice, less passive.  I tried to make the verb tenses more consistent.  I tried to strip out a lot of unnecessary words.  Hope that helps.
@Vultraz
Copy link
Contributor

Vultraz commented Nov 6, 2015

I glanced over this, and I noticed you use double spacing between your sentence fixes. Could you edit the PR to use single space? Also, don't use '--' (double dashes).

As for the content, some of the changes are good, but I'll have to do a full line-by-line review.

@irydacea
Copy link
Member

irydacea commented Nov 7, 2015

I haven't reviewed the whole thing yet (I'd rather leave it to vultraz to perform a pre-review), but there seem to be a lot of unexplained phrasing changes. Generally speaking, I'm not very likely to accept that kind of changes without prior discussion at this point.

@pkaction
Copy link
Author

Hi everyone. I was just trying to help out with some of the writing. There are many phrasing changes -- my goal was to make it more readable. It also makes a big difference for people who might want to translate it one day.

@Vultraz I can go through again, and remove the double-spacing and two-dashes. That's not a problem. Just let me know if you think it's worth the time. I'm not very familiar with how projects work on Github. Still new to the whole thing. I just wanted to try contributing. Let me know if you think there is some way I can help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants