Skip to content

Conversation

@invidian
Copy link
Contributor

Otherwise test suite will panic when an operation fails, which next steps depend on. This change should ensure clearer error messages and less false-negative test results.

The operation may fail e.g. when tests run is interrupted early.

Copilot AI review requested due to automatic review settings December 12, 2025 16:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves test reliability by converting assert calls to require for critical operations where subsequent test steps depend on success. This prevents panics and provides clearer error messages when tests are interrupted or fail.

Key changes:

  • Added require import from testify
  • Converted assert.Nil(t, err) to require.NoError(t, err) for critical operations
  • Converted assert.Equal to require.Equal for values that subsequent code depends on
  • Minor style improvements (variable declaration syntax, whitespace cleanup)

@invidian invidian force-pushed the invidian/fs-test-fixes branch 2 times, most recently from 82ddee0 to 314a36d Compare December 15, 2025 18:09
@invidian invidian force-pushed the invidian/fs-test-fixes branch 2 times, most recently from 548730b to e04b2de Compare December 16, 2025 09:15
@invidian invidian force-pushed the invidian/fs-test-fixes branch 4 times, most recently from 925b0f6 to 55eaff7 Compare January 6, 2026 08:49
@invidian invidian requested a review from cpuguy83 January 6, 2026 08:57
@invidian invidian force-pushed the invidian/fs-test-fixes branch from 55eaff7 to e0dd362 Compare January 6, 2026 09:40
@invidian invidian closed this Jan 8, 2026
@invidian invidian force-pushed the invidian/fs-test-fixes branch from e0dd362 to 6650b98 Compare January 8, 2026 06:43
@invidian invidian deleted the invidian/fs-test-fixes branch January 8, 2026 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants