Update dynhist to latest patch release #897
Open
+6
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the github.com/vearutop/dynhist-go dependency from v1.2.3 to v1.2.4. The newer version changes the histogram output format, specifically updating the header from "(N events)" to "(total count: N)", which required updates to test expectations.
- Updated dynhist-go dependency from v1.2.3 to v1.2.4
- Updated test expectations to match new histogram output format
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go.mod | Updates dynhist-go dependency version from v1.2.3 to v1.2.4 |
| go.sum | Adds checksums for new dynhist-go v1.2.4 and indirect dependency bool64/dev v0.2.43 |
| cmd/test2json2gha/summary_test.go | Updates expected histogram header format from "(4 events)" to "(total count: 4)" |
| cmd/test2json2gha/main_test.go | Updates expected histogram header format from "(5 events)" to "(total count: 5)" |
There was some changes to the output so the tests needed to be updated. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
cpuguy83
force-pushed
the
update_dynhist
branch
from
82811c6 to
bb0742a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some changes to the output so the tests needed to be updated.
Closes #879