Add target to build sprm only - #1207
Open
bchuo wants to merge 1 commit into
Open
Conversation
Signed-off-by: Brian Chuo <brianchuo@microsoft.com>
✅ Deploy Preview for dalec ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds <distro>/srpm targets to build and optionally sign source RPMs without executing binary build stages, addressing #1202.
Changes:
- Adds shared
rpmbuild -bssupport and RPM distro routing. - Preserves preprocessing, macros, platform handling, and signing.
- Adds unit, integration, signing, and target-list coverage.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
website/assets/includes/targets.txt |
Documents new SRPM targets. |
test/source_package_test.go |
Tests SRPM output and skipped build steps. |
test/signing_test.go |
Tests source-only package signing. |
test/linux_target_test.go |
Registers SRPM integration coverage. |
targets/linux/rpm/distro/pkg.go |
Implements SRPM construction and handling. |
targets/linux/rpm/distro/distro.go |
Registers the /srpm route. |
packaging/linux/rpm/rpmbuild.go |
Adds the source-only rpmbuild operation. |
packaging/linux/rpm/rpmbuild_test.go |
Verifies generated rpmbuild commands. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #1202
Special notes for your reviewer: