Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: skip install tools cmd #741

Merged
merged 12 commits into from
Aug 30, 2024

Commits on Aug 13, 2024

  1. Generate dynamic tool installation command

    Commented out the hardcoded install command and introduced a new method to dynamically generate the command based on the available package managers and missing tools in the tooling image. This enhancement increases flexibility and ensures the tooling image has all required tools installed using the detected package manager.
    
    Signed-off-by: Miaha Cybersec <MiahaCybersec@gmail.com>
    Miaha Cybersec authored and Miaha Cybersec committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    5dcbbc3 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Add 'rpm' to package managers and handle unsupported images

    Extended the list of package managers to include 'rpm' in the pkgmgr. Added error handling for unsupported RedHat and RockyLinux source policies due to missing busybox in their repos.
    
    Signed-off-by: Miaha Cybersec <MiahaCybersec@gmail.com>
    Miaha Cybersec authored and Miaha Cybersec committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    2595ad5 View commit details
    Browse the repository at this point in the history
  2. Refactor generateToolInstallCmd argument types.

    Changed `generateToolInstallCmd` to accept pointer of llb.State for better efficiency. Removed redundant `rpm` package manager as it cannot connect to RPM repos.
    
    Signed-off-by: Miaha Cybersec <MiahaCybersec@gmail.com>
    Miaha Cybersec authored and Miaha Cybersec committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    651a23d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e77cfe3 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Update RPM tests to include package manager validation

    Added `tdnf` as a required package manager in test cases for `Test_unpackAndMergeUpdates_RPM`. This ensures tests do not fail due to the absence of a specified package manager.
    
    Signed-off-by: Miaha Cybersec <MiahaCybersec@gmail.com>
    Miaha Cybersec authored and Miaha Cybersec committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    d2a763f View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Configuration menu
    Copy the full SHA
    e86cf2a View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Refactor tooling check loop in rpm.go

    Simplify the loop for checking required tools by using more descriptive variable names and range iteration syntax. This improves readability and maintainability of the code.
    
    Signed-off-by: Miaha Cybersec <MiahaCybersec@gmail.com>
    Miaha Cybersec authored and Miaha Cybersec committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    d866723 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ea8e9ff View commit details
    Browse the repository at this point in the history
  3. Update pkg/patch/patch.go

    Co-authored-by: Ashna Mehrotra <ashnamehrotra@gmail.com>
    Signed-off-by: Miaha <143584635+MiahaCybersec@users.noreply.github.com>
    MiahaCybersec and ashnamehrotra authored Aug 27, 2024
    Configuration menu
    Copy the full SHA
    1d57457 View commit details
    Browse the repository at this point in the history
  4. Update pkg/patch/patch.go

    Co-authored-by: Ashna Mehrotra <ashnamehrotra@gmail.com>
    Signed-off-by: Miaha <143584635+MiahaCybersec@users.noreply.github.com>
    MiahaCybersec and ashnamehrotra authored Aug 27, 2024
    Configuration menu
    Copy the full SHA
    7649122 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Refactor RPM package manager detection and tooling checks

    Simplify the detection of installed package managers and required tools by using `strings.Contains` instead of splitting the applications list. This change reduces nested loops and enhances code readability while maintaining functionality for checking missing tools and package managers.
    
    Signed-off-by: Miaha Cybersec <MiahaCybersec@gmail.com>
    Miaha Cybersec authored and Miaha Cybersec committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    9417747 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Configuration menu
    Copy the full SHA
    5983bea View commit details
    Browse the repository at this point in the history