fix: flakey custom unix test #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #615 +/- ##
==========================================
+ Coverage 32.51% 35.13% +2.62%
==========================================
Files 17 18 +1
Lines 1621 1386 -235
==========================================
- Hits 527 487 -40
+ Misses 1062 867 -195
Partials 32 32 ☔ View full report in Codecov by Sentry. |
sozercan
reviewed
May 10, 2024
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| # dockerd requires containerd snapshotter support to be enabled otherwise required features for buildkit are disabled. | |||
| docker build -t dind -<<EOF | |||
| FROM docker:24.0-dind | |||
| FROM docker:26.1.1-dind | |||
There was a problem hiding this comment.
do we need to pin to a patch version here?
sozercan
reviewed
May 10, 2024
| @@ -13,6 +13,10 @@ sock_dir="$(mktemp -d)" | |||
|
|
|||
| docker_custom_unix_id="$(docker run -d --privileged --mount=type=bind,source="${sock_dir}",target=/run --mount=type=volume,source="${DOCKER_DIND_VOLUME}",target=/var/lib/docker dind --group "$(id -g)")" | |||
|
|
|||
| until [ "$(docker inspect -f '{{.State.Status}}' $docker_custom_unix_id)" == "running" ]; do | |||
| sleep 0.1 | |||
There was a problem hiding this comment.
can you add a timeout logic here?
ashnamehrotra
force-pushed
the
test-custom-unix
branch
from
5b6f6d2
to
35965b2
Compare
cpuguy83
approved these changes
May 10, 2024
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
cpuguy83
force-pushed
the
test-custom-unix
branch
from
f8dbbd4
to
e237d8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in this pull request using active verbs such as Add, Remove, Replace ...
Upgrade dind image to docker:26.1.1-dind and add wait for dind container to status Running.
Closes #609