chore: update buildkit to 1.13.1 #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #532 +/- ##
==========================================
+ Coverage 32.51% 35.63% +3.12%
==========================================
Files 17 17
Lines 1621 1305 -316
==========================================
- Hits 527 465 -62
+ Misses 1062 808 -254
Partials 32 32 ☔ View full report in Codecov by Sentry. |
cpuguy83
requested changes
Mar 16, 2024
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
cpuguy83
requested changes
Mar 18, 2024
pkg/patch/patch.go
Outdated
Comment on lines
234
to
245
| var c console.Console | ||
| if cn, err := console.ConsoleFromFile(os.Stderr); err == nil { | ||
| c = cn | ||
| } | ||
| mode := progressui.AutoMode | ||
| if log.GetLevel() >= log.DebugLevel { | ||
| mode = progressui.PlainMode | ||
| } | ||
| display, err := progressui.NewDisplay(c, mode) | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
Suggested change
| var c console.Console | |
| if cn, err := console.ConsoleFromFile(os.Stderr); err == nil { | |
| c = cn | |
| } | |
| mode := progressui.AutoMode | |
| if log.GetLevel() >= log.DebugLevel { | |
| mode = progressui.PlainMode | |
| } | |
| display, err := progressui.NewDisplay(c, mode) | |
| if err != nil { | |
| return err | |
| } | |
| out := os.Stderr | |
| if cf, _ := console.ConsoleFromFile(os.Stderr); cf != nil { | |
| out = cf | |
| } | |
| mode := progressui.AutoMode | |
| if log.GetLevel() >= log.DebugLevel { | |
| mode = progressui.PlainMode | |
| } | |
| display, err := progressui.NewDisplay(out, mode) | |
| if err != nil { | |
| return err | |
| } |
There was a problem hiding this comment.
@cpuguy83 i removed ConsoleFromFile completely, wdyt?
There was a problem hiding this comment.
I think if you do that it will never do TTY mode?
There was a problem hiding this comment.
tested and works with tty (output is glitchy for whatever reason on my terminal, but it was the same before)
sozercan
force-pushed
the
chore-buildkit-130
branch
from
e670e30
to
bc84fdf
Compare
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
sozercan
changed the title
sozercan
changed the title
cpuguy83
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in this pull request using active verbs such as Add, Remove, Replace ...
Closes #<issue_ID>