fix: ignore cache for "apt update" #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuguy83
requested review from
jeremyrickard,
salaxander and
sozercan
as code owners
sozercan
changed the title
sozercan
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #364 +/- ##
==========================================
- Coverage 32.54% 32.29% -0.25%
==========================================
Files 17 17
Lines 1555 1567 +12
==========================================
Hits 506 506
- Misses 1020 1032 +12
Partials 29 29
☔ View full report in Codecov by Sentry. |
"apt update" should never be cached. This also shouldn't break caching for anything run after it unless the rootfs changed (ie. apt cache was actually updated). Signed-off-by: Brian Goff <cpuguy83@gmail.com>
cpuguy83
force-pushed
the
force_apt_update
branch
from
1e653d1
to
efe84ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"apt update" should never be cached.
This also shouldn't break caching for anything run after it unless the
rootfs changed (ie. apt cache was actually updated).