Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry pick #295 into 0.4 #314

Merged

Conversation

ashnamehrotra
Copy link
Contributor

Describe the changes in this pull request using active verbs such as Add, Remove, Replace ...

Closes #<issue_ID>

Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>

Signed-off-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! lgtm

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01% 🎉

Comparison is base (e9cba83) 29.30% compared to head (8cd8d51) 29.32%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-0.4     #314      +/-   ##
===============================================
+ Coverage        29.30%   29.32%   +0.01%     
===============================================
  Files               16       16              
  Lines             1498     1497       -1     
===============================================
  Hits               439      439              
+ Misses            1034     1033       -1     
  Partials            25       25              
Files Changed Coverage Δ
pkg/pkgmgr/rpm.go 33.24% <0.00%> (+0.08%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashnamehrotra ashnamehrotra merged commit 2225a24 into project-copacetic:release-0.4 Sep 22, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants