-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ignore errors flags #247
Merged
sozercan
merged 7 commits into
project-copacetic:main
from
anubhav06:ignore-errors-flag
Aug 22, 2023
Merged
feat: add ignore errors flags #247
sozercan
merged 7 commits into
project-copacetic:main
from
anubhav06:ignore-errors-flag
Aug 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anubhav Gupta <mail.anubhav06@gmail.com>
anubhav06
requested review from
jeremyrickard,
salaxander and
sozercan
as code owners
August 12, 2023 08:14
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #247 +/- ##
==========================================
+ Coverage 28.51% 29.30% +0.79%
==========================================
Files 16 16
Lines 1487 1498 +11
==========================================
+ Hits 424 439 +15
+ Misses 1037 1034 -3
+ Partials 26 25 -1
☔ View full report in Codecov by Sentry. |
sozercan
reviewed
Aug 14, 2023
anubhav06
force-pushed
the
ignore-errors-flag
branch
from
August 15, 2023 08:00
6539d33
to
bf15f30
Compare
Signed-off-by: Anubhav Gupta <mail.anubhav06@gmail.com>
anubhav06
force-pushed
the
ignore-errors-flag
branch
from
August 15, 2023 14:04
2566f0f
to
b3a86ec
Compare
sozercan
reviewed
Aug 15, 2023
Signed-off-by: Anubhav Gupta <mail.anubhav06@gmail.com>
sozercan
reviewed
Aug 22, 2023
Signed-off-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
sozercan
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM
ashnamehrotra
pushed a commit
to ashnamehrotra/copacetic
that referenced
this pull request
Aug 25, 2023
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--ignore-errors
flagCloses #203
How to test?
trivy image --vuln-type os --ignore-unfixed -f json -o nginx.1.21.6.json mcr.microsoft.com/oss/nginx/nginx:1.21.6
--ignore-errors
flag:--ignore-errors
flag enabled:We can see that despite the 2 errors, copa ignores them, and still produces an image