Skip to content

Update OWNERS #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Conversation

anishasthana
Copy link
Contributor

@anishasthana anishasthana commented Jul 10, 2023

This is the first step towards using openshift-ci to manage PRs and provision clusters for the MCAD repo.

I've based the list based on recent commits to the repo + recent reviewers for PRs.

cc @z103cb

@anishasthana
Copy link
Contributor Author

Related: openshift/release#41078

@z103cb
Copy link
Contributor

z103cb commented Jul 10, 2023

LGTM, but I would like @tardieu to have the final say on this change.

@z103cb z103cb requested review from z103cb and tardieu July 10, 2023 08:30
@asm582
Copy link
Member

asm582 commented Jul 10, 2023

I think dmatch01 should be added to reviewers list

@tardieu
Copy link
Member

tardieu commented Jul 10, 2023

+1 for @dmatch01 as a reviewer. Let's also add @metalcycling as an owner and reviewer, and @tardieu as a reviewer.

This is the first step towards using openshift-ci to manage PRs
and provision clusters for the MCAD repo.

Signed-off-by: Anish Asthana <anishasthana1@gmail.com>
@anishasthana
Copy link
Contributor Author

@tardieu can you take another look?

Copy link
Member

@tardieu tardieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishasthana
Copy link
Contributor Author

This PR shouldn't be affected by CI -- can I manually merge?

@anishasthana anishasthana merged commit 6d58335 into project-codeflare:main Jul 11, 2023
@anishasthana anishasthana deleted the update_owners branch July 11, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants