Skip to content

Operator Redesign #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Sep 20, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
1810542
Embed MCAD and InstaScale controllers
astefanutti Aug 8, 2023
b05e88f
Increase golangci-lint timeout
astefanutti Aug 10, 2023
a2d9747
fix duplicated kubeconfig CLI option
astefanutti Aug 11, 2023
9126bcf
Add MCAD APIs to runtime scheme
astefanutti Aug 11, 2023
3ee7ff0
Add InstaScale ConfigMap
astefanutti Aug 11, 2023
f04bd06
Update e2e setup
astefanutti Aug 11, 2023
6ed8ec9
Remove MCAD logs retrieval
astefanutti Aug 11, 2023
7982c90
Work-around conflict with MCAD custom metrics adapter port
astefanutti Aug 11, 2023
b3e5183
Fix InstaScale ConfigMap configuration
astefanutti Aug 11, 2023
01d0d43
Fix RayCluster RBAC
astefanutti Aug 11, 2023
40678f0
Remove deployment controllers
astefanutti Aug 11, 2023
a147984
Remove client package
astefanutti Aug 11, 2023
145d1f3
Update go.mod
astefanutti Aug 11, 2023
f82ecf4
Fix OLM upgrade workflow
astefanutti Aug 24, 2023
e23f092
Remove MCAD and InstaScale internal templates
astefanutti Aug 24, 2023
848a302
Remove MCAD and InstaScale CRDs
astefanutti Sep 5, 2023
5108c99
Update OLM ClusterServiceVersion
astefanutti Sep 5, 2023
4f44a83
Remove MCAD and InstaScale APIs
astefanutti Sep 8, 2023
92ef140
Remove MCAD and InstaScale APIs RBAC and samples
astefanutti Sep 8, 2023
46200fb
Remove code generation verify workflow
astefanutti Sep 8, 2023
d823875
Clean up operator roles
astefanutti Sep 8, 2023
d9ca65f
Use structured configuration
astefanutti Sep 13, 2023
21472df
Add quota API types to runtime scheme
astefanutti Sep 13, 2023
d22e2d1
Add controller manager structured config
astefanutti Sep 18, 2023
4f9b9ef
Init and load operator ConfigMap
astefanutti Sep 18, 2023
7069157
Remove openshift-goimports from tools.go
astefanutti Sep 19, 2023
a243e58
Update Go modules target in Makefile
astefanutti Sep 19, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove MCAD and InstaScale CRDs
  • Loading branch information
astefanutti committed Sep 19, 2023
commit 848a302848abbabed3b8b3af40f6f8fe8e1d318b
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,8 @@ defaults:
gofmt -w $(DEFAULTS_TEST_FILE)

.PHONY: manifests
manifests: controller-gen ## Generate WebhookConfiguration, ClusterRole and CustomResourceDefinition objects.
$(CONTROLLER_GEN) rbac:roleName=manager-role crd webhook paths="./..." output:crd:artifacts:config=config/crd/bases
manifests: controller-gen ## Generate RBAC objects.
$(CONTROLLER_GEN) rbac:roleName=manager-role webhook paths="./..."

.PHONY: generate
generate: controller-gen ## Generate code containing DeepCopy, DeepCopyInto, and DeepCopyObject method implementations.
Expand Down
19 changes: 0 additions & 19 deletions PROJECT
Original file line number Diff line number Diff line change
Expand Up @@ -6,23 +6,4 @@ plugins:
scorecard.sdk.operatorframework.io/v2: {}
projectName: codeflare-operator
repo: github.com/project-codeflare/codeflare-operator
resources:
- api:
crdVersion: v1
namespaced: true
controller: true
domain: codeflare.dev
group: codeflare
kind: MCAD
path: github.com/project-codeflare/codeflare-operator/api/v1alpha1
version: v1alpha1
- api:
crdVersion: v1
namespaced: true
controller: true
domain: codeflare.dev
group: codeflare
kind: InstaScale
path: github.com/project-codeflare/codeflare-operator/api/v1alpha1
version: v1alpha1
version: "3"
126 changes: 0 additions & 126 deletions config/crd/bases/codeflare.codeflare.dev_instascales.yaml

This file was deleted.

144 changes: 0 additions & 144 deletions config/crd/bases/codeflare.codeflare.dev_mcads.yaml

This file was deleted.

19 changes: 0 additions & 19 deletions config/crd/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,24 +2,5 @@
# since it depends on service name and namespace that are out of this kustomize package.
# It should be run by config/default
resources:
- bases/codeflare.codeflare.dev_mcads.yaml
- bases/codeflare.codeflare.dev_instascales.yaml
- mcad
#+kubebuilder:scaffold:crdkustomizeresource

patchesStrategicMerge:
# [WEBHOOK] To enable webhook, uncomment all the sections with [WEBHOOK] prefix.
# patches here are for enabling the conversion webhook for each CRD
#- patches/webhook_in_mcads.yaml
#- patches/webhook_in_instascales.yaml
#+kubebuilder:scaffold:crdkustomizewebhookpatch

# [CERTMANAGER] To enable cert-manager, uncomment all the sections with [CERTMANAGER] prefix.
# patches here are for enabling the CA injection for each CRD
#- patches/cainjection_in_mcads.yaml
#- patches/cainjection_in_instascales.yaml
#+kubebuilder:scaffold:crdkustomizecainjectionpatch

# the following config is for teaching kustomize how to do kustomization for CRDs.
configurations:
- kustomizeconfig.yaml
19 changes: 0 additions & 19 deletions config/crd/kustomizeconfig.yaml

This file was deleted.

7 changes: 0 additions & 7 deletions config/crd/patches/cainjection_in_instascales.yaml

This file was deleted.

7 changes: 0 additions & 7 deletions config/crd/patches/cainjection_in_mcads.yaml

This file was deleted.

16 changes: 0 additions & 16 deletions config/crd/patches/webhook_in_instascales.yaml

This file was deleted.

Loading