Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add backend for Darwin availability annotations. #857

Merged
merged 4 commits into from
Dec 15, 2022
Merged

Add backend for Darwin availability annotations. #857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f2070c1
Add backend for Darwin availability annotations.
bzbarsky-apple Dec 7, 2022
77035d2
Address review comment.
bzbarsky-apple Dec 14, 2022
251503d
Address review comment: don't hardcode the availability data filename.
bzbarsky-apple Dec 15, 2022
d4a0fe6
Address review comment: deprecating a container should deprecate its …
bzbarsky-apple Dec 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions src-electron/generator/matter/app/zap-templates/templates/app/helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -878,13 +878,8 @@ async function if_is_fabric_scoped_struct(type, options) {
let packageIds = await templateUtil.ensureZclPackageIds(this);
let st = await zclQuery.selectStructByName(this.global.db, type, packageIds);

if (st) {
// TODO: Should know whether a struct is fabric-scoped without sniffing its
// members.
let fields = await zclQuery.selectAllStructItemsById(this.global.db, st.id);
if (fields.find((i) => i.type.toLowerCase() == 'fabric_idx')) {
return options.fn(this);
}
if (st && st.isFabricScoped) {
return options.fn(this);
}

return options.inverse(this);
Expand Down
Loading