Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding helpers for zcl data types #772

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Adding helpers for zcl data types #772

merged 1 commit into from
Nov 7, 2022

Conversation

brdandu
Copy link
Collaborator

@brdandu brdandu commented Oct 26, 2022

  • Helper for getting size of zcl type
  • If helpers to check sign and size of data type

tecimovic
tecimovic approved these changes Oct 26, 2022
View reviewed changes
Copy link
Collaborator

@tecimovic tecimovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge it, since my comments are not blockers.... We should just overall start walking into direction of populating context more, and creating complex helpers less.

src-electron/generator/helper-zcl.js Outdated Show resolved Hide resolved
src-electron/generator/helper-zcl.js Outdated Show resolved Hide resolved
@brdandu brdandu force-pushed the bug/commandStructCleanupForCommandArguments/EMZIGBEE-10378 branch from 4648edb to 5bf716a Compare October 28, 2022 14:40
@brdandu brdandu force-pushed the bug/commandStructCleanupForCommandArguments/EMZIGBEE-10378 branch 3 times, most recently from 27e667f to 4beb4d1 Compare November 7, 2022 17:33
@brdandu
Adding helpers for zcl data types
c36bcf7 
- Helper for getting size of zcl type
- Adding size and sign of argument type to zcl_command_arguments helpers
- Creating a generic comparison helper instead of polluting with too many if helpers
- Minor cleanup to add command argument type size and sign
- bumping the feature level
- JIRA: EMZIGBEE-10378
@brdandu brdandu force-pushed the bug/commandStructCleanupForCommandArguments/EMZIGBEE-10378 branch from 4beb4d1 to c36bcf7 Compare November 7, 2022 18:09
@brdandu brdandu merged commit 80bcb29 into project-chip:master Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tecimovic tecimovic tecimovic approved these changes

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brdandu @tecimovic