Fixing the command argument optional attribute loading and fixing the zcl cli helper to take that into account #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
brdandu
commented
Sep 27, 2022
brdandu
commented
- Adding additional options to zcl_command_argument_type_to_cli_data_type_util function such that it can account for the the isOptional argument to return the precise CLI command argument
- The xml mentions optional=1 for the command arguments. Therefore accounting for that in the zcl-loader-silabs.js
- JIRA: EMZIGBEE-10318
… zcl cli helper to take that into account - Adding additional options to zcl_command_argument_type_to_cli_data_type_util function such that it can account for the the isOptional argument to return the precise CLI command argument - The xml mentions optional=1 for the command arguments. Therefore accounting for that in the zcl-loader-silabs.js - JIRA: EMZIGBEE-10318
JIRA: EMZIGBEE-10318
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.