Matter Cleanup for Chip Tool Repo #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzbarsky-apple
requested changes
Sep 21, 2022
brdandu
force-pushed
the
task/cleanupChipToolMatterRepo/ZAP#679
branch
from
a40fa5b to
e730753
Compare
|
@brdandu I see 4 different changes here and each of them could have been its own dedicated PR. That would make the process easier and not all changes will be blocked on one particular changes:
|
There was a problem hiding this comment.
This generally looks pretty good, but I'm still not convinced on the max behavior. See #737 (comment)
bzbarsky-apple
approved these changes
Oct 6, 2022
tecimovic
approved these changes
Oct 7, 2022
…d across different kinds of templates - Adding selectStructsWithClusterAssociation which takes the logic src-electron/generator/matter/chip-tool/templates/helper.js#structs_with_cluster_name to the backend(sql query). structs_with_clusters helper uses this instead of exports.structs_with_cluster_name - Updating cleanseLabelAsKebabCase so that it can be used instead of asDelimitedCommand - endpoint type was being treated as signed integer due to parsing logic in zcl-silabs-loader.js. Added a separate condition for this - Added generation tests for all the new helpers with an additional matter generation template - Adding the groupByStructName option to structs_with_clusters to avoid duplicate rows - Cleaning up the loader - Cleaning up the helpers in helper-zcl - For zcl data types, taking into account the signed attribute in the xml for numbers. If not mentioned then accounting for known exceptions such as single and double data types Throwing an error in as_type_max/min_value when language option is not specified Github: ZAP#679
brdandu
force-pushed
the
task/cleanupChipToolMatterRepo/ZAP#679
branch
from
8db1f24 to
8a3a89a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding generic helpers with less hardcoding such that they can be used across different kinds of templates
This PR will be associated with a CHIP repo PR project-chip/connectedhomeip#22762