Duplicate Endpoint #695
Duplicate Endpoint #695
Conversation
src-electron/db/query-config.js
Outdated
| @@ -20,1160 +20,1202 @@ | |||
| * | |||
| * @module DB API: user configuration queries against the database. | |||
| */ | |||
| const dbApi = require('./db-api.js') | |||
There was a problem hiding this comment.
The whole file seem to have changed and makes it very difficult to actually review the changes.
Can you fix this?
There was a problem hiding this comment.
During the call, I believe the agreed intention is to remove all the text (Edit/Copy/etc) and only leave icons. The tooltips can include the texts. For the expand / un-expand, let's use the default up / down arrow
e.g.
I am still the same issue for the UI.
src-electron/rest/user-data.js
Outdated
| @@ -20,744 +20,789 @@ | |||
| * | |||
| * @module REST API: user data | |||
| */ | |||
| const fs = require('fs') | |||
There was a problem hiding this comment.
The whole file seem to have changed and makes it very difficult to actually review the changes.
Can you fix this?
src/store/zap/actions.js
Outdated
| @@ -14,803 +14,820 @@ | |||
| * See the License for the specific language governing permissions and | |||
| * limitations under the License. | |||
| */ | |||
| import Vue from 'vue' | |||
There was a problem hiding this comment.
The whole file seem to have changed and makes it very difficult to actually review the changes.
Can you fix this?
src/util/common-mixin.js
Outdated
| @@ -15,198 +15,215 @@ | |||
| * limitations under the License. | |||
| */ | |||
|
|
|||
| import * as Util from './util' | |||
There was a problem hiding this comment.
The whole file seem to have changed and makes it very difficult to actually review the changes.
Can you fix this?
Amirreza-Ghasemkhani
force-pushed
the
tdj_528_duplicate
branch
2 times, most recently
from
0f632ff to
11501dc
Compare
Amirreza-Ghasemkhani
force-pushed
the
tdj_528_duplicate
branch
from
fd24b1a to
87a05b4
Compare
src-electron/rest/user-data.js
Outdated
| attrubute) | ||
| }) | ||
| }) | ||
| } catch (err) { |
There was a problem hiding this comment.
Instead of catching the error here, the exception should just bubble to httpPostDuplicateEndpointType() and the error should be printed / responded there. otherwise httpPostDuplicateEndpointType() would just fail silently.
src/components/ZclEndpointCard.vue
Outdated
| @@ -394,8 +427,9 @@ export default { | |||
| }, | |||
| created() { | |||
| if (this.$serverGet != null) { | |||
| this.selectedAttributes= [] | |||
| this.selectedReporting =[] | |||
| this.selectedservers = [] | |||
There was a problem hiding this comment.
typo selectedservers?
* chore: resolve conflicts * chore: clean space * chore: resolving conflict * fix: fix duplicate issue after rebase * chore: fix typo issue and remove catch for duplicate function Co-authored-by: A.ghasemkhani <a.ghasemkhaniii@gmail.com>
#528