-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating dotdot loader #1432
Updating dotdot loader #1432
Conversation
8f04e14
to
33dd5bd
Compare
a.name.endsWith('u') || | ||
!a.name.includes('int') | ||
? 0 | ||
: 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we do something similar on the zcl-loader-silabs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
XMLs loaded through zcl-loader-silabs (Matter/Zigbee) expect the isSigned field to be specified in the XML. If not they do some regex matching - /^int[0-9]{1,2}s?$/.test(a.$.name)
.
33dd5bd
to
3326112
Compare
* making sure discriminator ref is set correctly for all strings * making sure is_signed is set correctly for all numbers * dealing with subatomics (by processing them last) * picking up atomic size from length property fixing incorrect value in zcl-loader-consecutive.test.js and adding string count test in zcl-loader.test.js
3326112
to
61a5478
Compare
In
zcl-loader-dotdot.js
:making sure discriminator ref is set correctly for all strings
making sure is_signed is set correctly for all numbers
dealing with subatomics (by processing them last)
picking up atomic size from length property
fixing incorrect value in
zcl-loader-consecutive.test.js
and adding string count test tozcl-loader.test.js