Update the .zap file when Studio project updates to a new GSDK #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
brdandu
commented
Sep 23, 2024
brdandu
commented
- Update the uc_upgrade target for apack.json
- Add the upgrade zap file function which updates the top level json packages for the .zap file based on the gsdk being used for the project.
- The code goes through a temporary directory where .zap files are stored for Studio and updates all the .zap files in that directory
- The top level upgrade packages are matched based on type and category
- Other minor cleanup
- JIRA: ZAPP-1362
brdandu
force-pushed
the
improvement/upgradeZapFileForStudioProjectUpgrade/ZAPP-1362
branch
from
628915e
to
93399be
Compare
brdandu
force-pushed
the
improvement/upgradeZapFileForStudioProjectUpgrade/ZAPP-1362
branch
3 times, most recently
from
abf0a60
to
6f4cac2
Compare
tecimovic
approved these changes
Sep 27, 2024
| * @param {*} dir | ||
| * @returns all .zap files in the given directory | ||
| */ | ||
| function findZapFiles(dir) { |
There was a problem hiding this comment.
I thought there was already some logic that finds all the zap files in a directory? We use that for the file opening, since we only get "project directory" from UC...
There was a problem hiding this comment.
I just knew about the ${tempContentFolder} which has the .zap file for upgrade process. It is a temporary directory where the upgrade is performed. Just pass that here. Do not know about any other logic here.
brdandu
force-pushed
the
improvement/upgradeZapFileForStudioProjectUpgrade/ZAPP-1362
branch
from
6f4cac2
to
ed893a6
Compare
brdandu
requested review from
ethanzhouyc,
tbrkollar,
dhchandw and
tecimovic
paulr34
approved these changes
Oct 4, 2024
- Update the uc_upgrade target for apack.json - Add the upgrade zap file function which updates the top level json packages for the .zap file based on the gsdk being used for the project. - The code goes through a temporary directory where .zap files are stored for Studio and updates all the .zap files in that directory - The top level upgrade packages are matched based on type and category - Other minor cleanup - Cleaning up the directory flag to -d and adding the no load failure flag when packages are not present - Adding unit tests for the upgrade process - JIRA: ZAPP-1362
brdandu
force-pushed
the
improvement/upgradeZapFileForStudioProjectUpgrade/ZAPP-1362
branch
from
ed893a6
to
b214bbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.