-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove wrong condition from ZapConfig #1385
fix: remove wrong condition from ZapConfig #1385
Conversation
f59cd21
to
cf1ba5e
Compare
src/pages/ZapConfig.vue
Outdated
(zfp) => zfp.type != dbEnum.packageType.zclXmlStandalone | ||
) | ||
currentZapFileZclPacakges = this.currentZapFilePackages.filter( | ||
(zfp) => zfp.type == dbEnum.packageType.zclProperties | ||
) | ||
|
||
currentZapFileTemplatePacakges = this.currentZapFilePackages.filter( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about currentZapFileZclPacakges.map below
src/pages/ZapConfig.vue
Outdated
let currentZapFileZclPacakges = [] | ||
let currentTopLevelZapFilePacakges = [] | ||
let currentZapFileTemplatePacakges = [] | ||
console.log(result.data.zapFilePackages) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Get rid of console.log
let currentZapFileTemplatePacakges = [] | ||
console.log(result.data.zapFilePackages) | ||
let currentZapFileZclPackages = [] | ||
let currentTopLevelZapFilePackages = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the changes to currentTopLevelZapFilePacakges.length below?
@@ -688,18 +688,20 @@ export default { | |||
this.filePath = result.data.filePath | |||
this.open = result.data.open | |||
this.currentZapFilePackages = result.data.zapFilePackages | |||
let currentZapFileZclPacakges = [] | |||
let currentTopLevelZapFilePacakges = [] | |||
let currentZapFileTemplatePacakges = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about currentZapFileTemplatePacakges.map
below?
@@ -716,16 +717,13 @@ export default { | |||
this.zclPropertiesRow.length == currentZapFileZclPacakges.length || | |||
this.zclPropertiesRow.length == 1 | |||
) { | |||
// We shortcut this page, if the number of packages in the zap file | |||
// and the number of packages loaded in the backend are the same. | |||
if (this.zclGenRow.length == currentZapFileTemplatePacakges.length) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a typo that's probably breaking everything
src/pages/ZapConfig.vue
Outdated
@@ -716,16 +717,13 @@ export default { | |||
this.zclPropertiesRow.length == currentZapFileZclPacakges.length || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be "currentZapFileZclPackages"
6bd469f
to
ab6ac00
Compare
@@ -40,4 +40,11 @@ describe('Check theme functionality', () => { | |||
cy.rendererApi(rendApi.id.setDarkTheme, 'false') | |||
cy.get('body').should('have.class', 'body--light') | |||
}) | |||
it('Zigbee mode', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From next time add a description on what the test is testing. Difficult to understand what this might be testing in the first go.
No description provided.