Fix Darwin name determination for global structs and enums. #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksperling-apple
approved these changes
Jul 26, 2024
brdandu
reviewed
Jul 26, 2024
There was a problem hiding this comment.
Can this lead to backwards compatibility issues if someone has new zap and old gsdk?
Should these changes be tied to some classification of a new vs old gsdk?
There was a problem hiding this comment.
It can't, because in old SDK there are no global structs and clusterName is never 'Globals'.
brdandu
approved these changes
Jul 26, 2024
brdandu
reviewed
Jul 26, 2024
bzbarsky-apple
force-pushed
the
darwin-global-codegen
branch
from
d8795cb
to
96f0a9f
Compare
The naming pattern is a bit different from cluster-specific ones.
bzbarsky-apple
force-pushed
the
darwin-global-codegen
branch
from
96f0a9f
to
c6682aa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1374 +/- ##
==========================================
- Coverage 66.00% 65.76% -0.25%
==========================================
Files 194 194
Lines 20528 20693 +165
Branches 4455 4505 +50
==========================================
+ Hits 13550 13608 +58
- Misses 6978 7085 +107 ☔ View full report in Codecov by Sentry. |
dhchandw
pushed a commit
to dhchandw/zap
that referenced
this pull request
Jul 26, 2024
…chip#1374) The naming pattern is a bit different from cluster-specific ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The naming pattern is a bit different from cluster-specific ones.