-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generation performance enhancements #1348
Conversation
c26b5a5
to
cd16960
Compare
974e0fd
to
2e32fd0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add documentation to our GitHub developer documentation on how to do profiling for generation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I will do that on a separate commit....
@@ -752,7 +764,9 @@ async function generateSingleTemplate( | |||
disableDeprecationWarnings: false, | |||
} | |||
) { | |||
env.logInfo(`Start generating from template: ${genTemplateJsonPackage?.path}`) | |||
let genStart = process.hrtime.bigint() | |||
//console.log(`Start generating from template: ${singleTemplatePkg?.path}`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep the console.log? I think it is generally nice to see this during all our generations instead of seeing it in some hidden form unless logInfo does console.log.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Console.log prints out the totals. I think it would be too much clutter if we print out these individual templates.
`Finish generating from template: ${genTemplateJsonPackage?.path}` | ||
`Finish generating from template: ${ | ||
singleTemplatePkg?.path | ||
}: ${util.duration(nsDuration)}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, do we continue to get the cumulative generation time like we did before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that didn't change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confused what really happened here between these test.js files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At some point the numbers shifted.
We have test data: matter1/2/3/4.
Then we had tests: matter1/2/3/4.
However Matter test 3 started using data 4. So when I added data 5, I would create test 4 and that felt stupid.
So I moved matter4 test to be named matter-3-1, since it uses test data 3 and then a new test data 4 can be used by matter test 4, so that the numbers align.
Further performance enhancements...