Skip to content

Commit

Permalink
GitHub action upgrade: upgrade set-output operator. (#756)
Browse files Browse the repository at this point in the history
fix Github warnings about actions using deprecated node 12
  • Loading branch information
Jing T authored Oct 26, 2022
1 parent d284738 commit 6694fa4
Show file tree
Hide file tree
Showing 5 changed files with 26 additions and 22 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/cypress.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ jobs:
os: [ubuntu-22.04]

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v2
uses: actions/setup-node@v3.0.0
with:
node-version: ${{ matrix.node-version }}
cache: 'npm'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/mattercypress.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ jobs:
os: [ubuntu-22.04]

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v2
uses: actions/setup-node@v3.0.0
with:
node-version: ${{ matrix.node-version }}
cache: 'npm'
Expand Down
34 changes: 19 additions & 15 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:

steps:
- name: Check out Git repository
uses: actions/checkout@v2
uses: actions/checkout@v3

- name: Install Node.js, NPM and Yarn
uses: actions/setup-node@v3.0.0
Expand Down Expand Up @@ -122,7 +122,9 @@ jobs:
run: |
unzip dist/zap-mac.zip -d dist/zap-mac
./dist/zap-mac/zap.app/Contents/MacOS/zap --version
echo "::set-output name=version::$(./dist/zap-mac/zap.app/Contents/MacOS/zap --version)"
echo 'version<<EOF' >> $GITHUB_OUTPUT
./dist/zap-mac/zap.app/Contents/MacOS/zap --version >> $GITHUB_OUTPUT
echo 'EOF' >> $GITHUB_OUTPUT
rm -rf dist/zap-mac
- name: ZAP version (macOS) - Verify exe running
uses: nick-fields/assert-action@v1
Expand All @@ -145,7 +147,9 @@ jobs:
run: |
unzip dist/zap-linux.zip -d dist/zap-linux
./dist/zap-linux/zap --version
echo "::set-output name=version::$(./dist/zap-linux/zap --version)"
echo 'version<<EOF' >> $GITHUB_OUTPUT
./dist/zap-linux/zap --version >> $GITHUB_OUTPUT
echo 'EOF' >> $GITHUB_OUTPUT
rm -rf dist/zap-linux
- name: ZAP version (Linux) - Verify exe running
uses: nick-fields/assert-action@v1
Expand All @@ -166,8 +170,8 @@ jobs:
id: linux_apack_setup
if: startsWith(matrix.os, 'ubuntu')
run: |
echo "::set-output name=linuxBaseDir::$(./node_modules/7zip-bin/linux/x64/7za l ./dist/zap-linux.zip | grep apack.json)"
echo "::set-output name=linuxAsarDir::$(npx asar l ./dist/linux-unpacked/resources/app.asar | grep apack.json)"
echo "linuxBaseDir=$(./node_modules/7zip-bin/linux/x64/7za l ./dist/zap-linux.zip | grep apack.json)" >> $GITHUB_OUTPUT
echo "linuxAsarDir=$(npx asar l ./dist/linux-unpacked/resources/app.asar | grep apack.json)" >> $GITHUB_OUTPUT
- name: Verify apack.json exists in Linux package .zip package
uses: nick-fields/assert-action@v1
if: startsWith(matrix.os, 'ubuntu')
Expand All @@ -187,11 +191,11 @@ jobs:
id: nonlinux_apack_setup
if: startsWith(matrix.os, 'macos')
run: |
echo "::set-output name=winBaseDir::$(./node_modules/7zip-bin/mac/x64/7za l ./dist/zap-win.zip | grep apack.json)"
echo "::set-output name=winAsarDir::$(npx asar l ./dist/win-unpacked/resources/app.asar | grep apack.json)"
echo "::set-output name=macBaseDir::$(./node_modules/7zip-bin/mac/x64/7za l ./dist/zap-mac.zip | grep apack.json)"
echo "::set-output name=macX64AsarDir::$(npx asar l ./dist/mac-universal/zap.app/Contents/Resources/app-x64.asar | grep apack.json)"
echo "::set-output name=macArm64AsarDir::$(npx asar l ./dist/mac-universal/zap.app/Contents/Resources/app-arm64.asar | grep apack.json)"
echo "winBaseDir=$(./node_modules/7zip-bin/mac/x64/7za l ./dist/zap-win.zip | grep apack.json)" >> $GITHUB_OUTPUT
echo "winAsarDir=$(npx asar l ./dist/win-unpacked/resources/app.asar | grep apack.json)" >> $GITHUB_OUTPUT
echo "macBaseDir=$(./node_modules/7zip-bin/mac/x64/7za l ./dist/zap-mac.zip | grep apack.json)" >> $GITHUB_OUTPUT
echo "macX64AsarDir=$(npx asar l ./dist/mac-universal/zap.app/Contents/Resources/app-x64.asar | grep apack.json)" >> $GITHUB_OUTPUT
echo "macArm64AsarDir=$(npx asar l ./dist/mac-universal/zap.app/Contents/Resources/app-arm64.asar | grep apack.json)" >> $GITHUB_OUTPUT
- run: echo "${{ steps.nonlinux_apack_setup.outputs.winBaseDir }}"
- name: Verify apack.json exists in Windows .zip package
uses: nick-fields/assert-action@v1.1.0
Expand Down Expand Up @@ -230,31 +234,31 @@ jobs:
comparison: contains

- name: Archive Windows .zip file
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
if: startsWith(matrix.os, 'macos')
with:
name: zap-win-zip
path: dist/zap*-win.zip
- name: Archive macOS .zip file
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
if: startsWith(matrix.os, 'macos')
with:
name: zap-mac-zip
path: dist/zap*-mac.zip
- name: Archive Linux .zip file
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
if: startsWith(matrix.os, 'ubuntu')
with:
name: zap-linux-zip
path: dist/zap*-linux.zip
- name: Archive Linux .rpm file
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
if: startsWith(matrix.os, 'ubuntu')
with:
name: zap-linux-rpm
path: dist/zap*.rpm
- name: Archive Linux .deb file
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
if: startsWith(matrix.os, 'ubuntu')
with:
name: zap-linux-deb
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sonarcloud.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
os: [ubuntu-latest]

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis
- name: SonarCloud Scan
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/zap.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ jobs:
os: [ubuntu-latest]

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
uses: actions/setup-node@v3.0.0
with:
node-version: ${{ matrix.node-version }}
cache: 'npm'
Expand Down

0 comments on commit 6694fa4

Please sign in to comment.