Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DistributedComplianceLedger #24

Merged
merged 10 commits into from
Aug 30, 2024
Merged

Add DistributedComplianceLedger #24

merged 10 commits into from
Aug 30, 2024

Conversation

jcps07
Copy link
Collaborator

@jcps07 jcps07 commented Jun 20, 2024

Added file with DCL intro and FAQ

@jcps07 jcps07 added the documentation Improvements or additions to documentation label Jun 20, 2024
@CLAassistant
Copy link

CLAassistant commented Jun 20, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sammachin
Copy link
Collaborator

@jcps07 can you move the md file into a new folder under content called Guides

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Preview deployed at https://d1teub3jrrfss6.cloudfront.net/pr-24

@github-actions GitHub Actions
Copy link

Preview deployed at https://d1teub3jrrfss6.cloudfront.net/pr-24

@github-actions GitHub Actions
Copy link

Preview deployed at https://d1teub3jrrfss6.cloudfront.net/pr-24

1 similar comment
@github-actions GitHub Actions
Copy link

Preview deployed at https://d1teub3jrrfss6.cloudfront.net/pr-24

@sammachin sammachin requested a review from Vyrastas July 10, 2024 14:32
@sammachin
Copy link
Collaborator

@Vyrastas Could you do an editorial review on this guide please, the preview is at https://d1teub3jrrfss6.cloudfront.net/pr-24/guides/distributedcomplianceledger/

Vyrastas
Vyrastas suggested changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@Vyrastas Vyrastas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some general comments

content/Guides/_index.md Outdated Show resolved Hide resolved
content/Guides/DistributedComplianceLedger.md Outdated Show resolved Hide resolved
content/Guides/DistributedComplianceLedger.md Outdated Show resolved Hide resolved
content/Guides/DistributedComplianceLedger.md Outdated Show resolved Hide resolved
content/Guides/DistributedComplianceLedger.md Outdated Show resolved Hide resolved
content/Guides/DistributedComplianceLedger.md Outdated Show resolved Hide resolved
@jcps07 @Vyrastas
Update content/Guides/_index.md
b078507 
Implemented suggestion.

Co-authored-by: Jeff Bumgardner <jbumgardner@google.com>
@github-actions GitHub Actions
Copy link

Preview deployed at https://d1teub3jrrfss6.cloudfront.net/pr-24

@github-actions GitHub Actions
Copy link

Preview deployed at https://d1teub3jrrfss6.cloudfront.net/pr-24

Vyrastas
Vyrastas approved these changes Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@Vyrastas Vyrastas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one nit

@sammachin @Vyrastas
Update content/Guides/DistributedComplianceLedger.md
882ed47 
Co-authored-by: Jeff Bumgardner <jbumgardner@google.com>
@github-actions GitHub Actions
Copy link

Preview deployed at https://d1teub3jrrfss6.cloudfront.net/pr-24

@hawk248
Copy link

hawk248 commented Aug 27, 2024

approved

@sammachin sammachin merged commit 19991b0 into project-chip:main Aug 30, 2024
3 checks passed
@github-actions GitHub Actions
Copy link

Preview deployed at https://d1teub3jrrfss6.cloudfront.net/pr-24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sammachin sammachin sammachin left review comments

@Vyrastas Vyrastas Vyrastas approved these changes

@hawk248 hawk248 hawk248 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jcps07 @CLAassistant @sammachin @hawk248 @Vyrastas