-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #19 - Added new device types in the 1.3 specification #21
Fixes #19 - Added new device types in the 1.3 specification #21
Conversation
…on (from 0.9 ballot). Note that not sure if Water Freeze Detector and Rain Sensor are supported and certifiable. Needs checking.
…nd Device Energy Management device types.
Given the clusters used by the two mentioned device type did pass SVE, I'm not aware that these should NOT be a part of 1.3? |
- [On/Off Light](#onoff-light) | ||
- [Dimmable Light](#dimmable-light) | ||
- [Color Temperature Light](#color-temperature-light) | ||
- [Extended Color Light](#extended-color-light) | ||
- Smart Plugs/Outlets and Other Actuators |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it intentional to remove these headings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No! - I think my editor did that - I'll revert.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The editor removed it because it didn't have extra heading levels - so I added those in below.
Let me know if I've messed up the sections.
- [On/Off Sensor](#onoff-sensor) | ||
- [Smoke CO Alarm](#smoke-co-alarm) | ||
- [Water Freeze Detector](#water-freeze-detector) | ||
- [Water Leak Detector](#water-leak-detector) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the water Freeze Detector and Rain Sensor certifiable device types? It looks to me that they use the same clusters (Boolean State) as Water Leak detector ? So did these therefore also get through 1.3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is certainly my impression, we are testing clusters at certification and not device types (for now) and the clusters did land as a part of 1.3.
I assume we are talking about Water Freeze Detector and Rain Sensor. As you say these use the same underlying cluster (Boolean State) so I'm assuming that they are, but Rob's email for 0.9 ballot didn't explicitly mention them, but did mention Water Leak detector. |
I can not speak to the reason for that, but I would assume it is a simple oversight. The main focus was on the leakage detector, the water freeze detector and rain sensor was "bolted on" during the development since they were obvious device types that could easily be constructed using the proposed clusters, so often the water management effort was referred to as just leakage and valve 🤷🏻♂️ I'm not sure who can give the final answer here 🤔 @robszewczyk do you have any input here? FYI: They are all mentioned in the slide deck from the plenary held just before the Singapore AMM as a part of the finalized 0.9 ballot. |
I assume you have already sorted this out, but anyway, they are in the Device Library spec for v1.3:
|
Added new device types in the 1.3 specification (from 0.9 ballot). Note that not sure if Water Freeze Detector and Rain Sensor are supported and certifiable. Needs checking.