Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop treating an ack we are not expecting as a fatal error. #9875

Merged

Conversation

bzbarsky-apple
Copy link
Contributor

We can get a message with a piggybacked ack for a message we have
already gotten a standalone ack for. In this case we should process
the message, not drop it.

Fixes #7909

Problem

See above

Change overview

See above

Testing

New unit test written to cover this case. Fails without the code changes, passes with.

We can get a message with a piggybacked ack for a message we have
already gotten a standalone ack for.  In this case we should process
the message, not drop it.

Fixes project-chip#7909
@github-actions
Copy link

Size increase report for "gn_qpg-example-build" from 0ade2d5

File Section File VM
chip-qpg6100-lighting-example.out .text -16 -16
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'

Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:

sections,vmsize,filesize
[Unmapped],0,16
.debug_str,0,3
.debug_frame,0,-8
.text,-16,-16
.debug_line,0,-57
.debug_ranges,0,-64
.debug_loc,0,-94
.debug_info,0,-232


@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from 0ade2d5

File Section File VM
chip-lock.elf text -16 -16
chip-shell.elf text -16 -16
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_frame,0,-8
text,-16,-16
.debug_line,0,-56
.debug_ranges,0,-64
.debug_loc,0,-92
.debug_info,0,-228

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.debug_frame,0,-8
text,-16,-16
.debug_line,0,-56
.debug_ranges,0,-64
.debug_loc,0,-92
.debug_info,0,-124


@github-actions
Copy link

Size increase report for "esp32-example-build" from 0ade2d5

File Section File VM
chip-all-clusters-app.elf .flash.text -20 -20
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
[Unmapped],0,20
.debug_frame,0,-16
.flash.text,-20,-20
.debug_ranges,0,-64
.debug_loc,0,-72
.debug_line,0,-97
.debug_str,0,-119
.debug_info,0,-400


@bzbarsky-apple bzbarsky-apple merged commit a62ee31 into project-chip:master Sep 22, 2021
@bzbarsky-apple bzbarsky-apple deleted the handle-duplicate-acks branch September 22, 2021 18:36
doru91 pushed a commit to doru91/connectedhomeip that referenced this pull request Oct 26, 2021
…chip#9875)

We can get a message with a piggybacked ack for a message we have
already gotten a standalone ack for.  In this case we should process
the message, not drop it.

Fixes project-chip#7909

Signed-off-by: Doru Gucea <doru-cristian.gucea@nxp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate ACK to same message id will cause receiver reject the message
6 participants