-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop treating an ack we are not expecting as a fatal error. #9875
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:handle-duplicate-acks
Sep 22, 2021
Merged
Stop treating an ack we are not expecting as a fatal error. #9875
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:handle-duplicate-acks
Sep 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
carol-apple,
chrisdecenzo,
Damian-Nordic,
erjiaqing,
franck-apple,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
shana-apple,
tcarmelveilleux,
turon,
vivien-apple,
woody-apple and
yunhanw-google
September 22, 2021 01:05
Damian-Nordic
approved these changes
Sep 22, 2021
msandstedt
approved these changes
Sep 22, 2021
saurabhst
approved these changes
Sep 22, 2021
bzbarsky-apple
force-pushed
the
handle-duplicate-acks
branch
from
September 22, 2021 14:25
be54dab
to
21adf5d
Compare
LuDuda
approved these changes
Sep 22, 2021
woody-apple
approved these changes
Sep 22, 2021
bzbarsky-apple
force-pushed
the
handle-duplicate-acks
branch
from
September 22, 2021 17:09
21adf5d
to
1489829
Compare
We can get a message with a piggybacked ack for a message we have already gotten a standalone ack for. In this case we should process the message, not drop it. Fixes project-chip#7909
bzbarsky-apple
force-pushed
the
handle-duplicate-acks
branch
from
September 22, 2021 17:18
1489829
to
1d4fa1b
Compare
Size increase report for "gn_qpg-example-build" from 0ade2d5
Full report output
|
Size increase report for "nrfconnect-example-build" from 0ade2d5
Full report output
|
Size increase report for "esp32-example-build" from 0ade2d5
Full report output
|
doru91
pushed a commit
to doru91/connectedhomeip
that referenced
this pull request
Oct 26, 2021
…chip#9875) We can get a message with a piggybacked ack for a message we have already gotten a standalone ack for. In this case we should process the message, not drop it. Fixes project-chip#7909 Signed-off-by: Doru Gucea <doru-cristian.gucea@nxp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can get a message with a piggybacked ack for a message we have
already gotten a standalone ack for. In this case we should process
the message, not drop it.
Fixes #7909
Problem
See above
Change overview
See above
Testing
New unit test written to cover this case. Fails without the code changes, passes with.