-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve various logging to make it easier to undestand what happened. #9868
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:improve-logging
Sep 22, 2021
Merged
Improve various logging to make it easier to undestand what happened. #9868
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:improve-logging
Sep 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specific changes: 1) Consistent formatting for message counters. 2) Consistent formatting for message types. 3) Consistent formatting of protocol ids. 4) Include the exchange context in various logging so we know which actual interaction/exchange is involved. 5) Include message counters in more places so we know which message is involved.
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
carol-apple,
cecille,
chrisdecenzo,
Damian-Nordic,
emargolis,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
sagar-apple,
saurabhst,
shana-apple,
tcarmelveilleux,
vivien-apple and
woody-apple
September 21, 2021 20:10
woody-apple
approved these changes
Sep 21, 2021
Size increase report for "gn_qpg-example-build" from dbbe48d
Full report output
|
Size increase report for "nrfconnect-example-build" from dbbe48d
Full report output
|
Size increase report for "esp32-example-build" from dbbe48d
Full report output
|
jmeg-sfy
approved these changes
Sep 22, 2021
tcarmelveilleux
approved these changes
Sep 22, 2021
Damian-Nordic
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specific changes:
actual interaction/exchange is involved.
involved.
Problem
Change overview
See above.
Testing
Ensured that I can do ble-wifi pairing, and looked at the logging to make sure that I am seeing the things I expect to see.