Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve various logging to make it easier to undestand what happened. #9868

Merged
merged 2 commits into from
Sep 22, 2021

Conversation

bzbarsky-apple
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple commented Sep 21, 2021

Specific changes:

  1. Consistent formatting for message counters.
  2. Consistent formatting for message types.
  3. Consistent formatting of protocol ids.
  4. Include the exchange context in various logging so we know which
    actual interaction/exchange is involved.
  5. Include message counters in more places so we know which message is
    involved.

Problem

  • Our send/receive logging is not consistent for message types: send logs them as decimal, receive logs them as hex
  • A bunch of our send/receive logging does not make it clear which message is involved, or which exchange is involved.

Change overview

See above.

Testing

Ensured that I can do ble-wifi pairing, and looked at the logging to make sure that I am seeing the things I expect to see.

Specific changes:

1) Consistent formatting for message counters.
2) Consistent formatting for message types.
3) Consistent formatting of protocol ids.
4) Include the exchange context in various logging so we know which
   actual interaction/exchange is involved.
5) Include message counters in more places so we know which message is
   involved.
@github-actions
Copy link

Size increase report for "gn_qpg-example-build" from dbbe48d

File Section File VM
chip-qpg6100-lighting-example.out .text 300 300
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'

Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:

sections,vmsize,filesize
.text,300,300
.debug_line,0,89
.debug_frame,0,16
.shstrtab,0,1
.debug_str,0,-15
.symtab,0,-32
.strtab,0,-45
.debug_ranges,0,-160
.debug_loc,0,-285
[Unmapped],0,-300
.debug_info,0,-5553


@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from dbbe48d

File Section File VM
chip-shell.elf text 176 176
chip-shell.elf rodata 152 148
chip-lock.elf text 156 156
chip-lock.elf rodata 144 144
chip-lock.elf device_handles 4 4
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
text,176,176
rodata,148,152
.debug_line,0,93
.debug_loc,0,22
.debug_frame,0,12
.debug_str,0,-14
.debug_abbrev,0,-32
.symtab,0,-32
.debug_ranges,0,-192
.debug_info,0,-1281

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
text,156,156
rodata,144,144
.debug_loc,0,94
.debug_line,0,63
.debug_frame,0,12
device_handles,4,4
.shstrtab,0,1
.debug_str,0,-14
.debug_abbrev,0,-32
.strtab,0,-45
.symtab,0,-64
.debug_ranges,0,-192
.debug_info,0,-5323


@github-actions
Copy link

Size increase report for "esp32-example-build" from dbbe48d

File Section File VM
chip-all-clusters-app.elf .flash.text 184 184
chip-all-clusters-app.elf .flash.rodata 136 136
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_loc,0,451
.flash.text,184,184
.debug_line,0,154
.flash.rodata,136,136
.strtab,0,70
.debug_frame,0,48
.debug_aranges,0,8
.shstrtab,0,2
.debug_abbrev,0,-5
.debug_str,0,-14
[Unmapped],0,-320
.debug_ranges,0,-336
.debug_info,0,-7206


@bzbarsky-apple bzbarsky-apple merged commit f7c5127 into project-chip:master Sep 22, 2021
@bzbarsky-apple bzbarsky-apple deleted the improve-logging branch September 22, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants