-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running make does not build platform #97
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan-apple
requested review from
anush-apple,
BroderickCarlin,
chrisdecenzo,
gerickson,
hawk248,
robszewczyk,
tpmanley and
woody-apple
as code owners
March 23, 2020 22:52
FYI @sagar-apple |
gerickson
approved these changes
Mar 23, 2020
woody-apple
approved these changes
Mar 23, 2020
hawk248
approved these changes
Mar 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
mkardous-silabs
referenced
this pull request
in SiliconLabs/watt-sandbox
Oct 6, 2022
…BaseApplication files Merge in WMN_TOOLS/matter from MATTER-753-refactor-onoff-plug-apptask-to-inherit-from-base-application to silabs Squashed commit of the following: commit 2d4848a34b9eb516734b3be0494e82ace7f1318f Author: Louis-Philip Béliveau <lobelive@0018239.silabs.com> Date: Wed Sep 14 10:56:37 2022 -0400 Refactoring of onoffplug app to use the BaseApplication files
jmartinez-silabs
referenced
this pull request
in SiliconLabs/matter
Oct 13, 2022
…tion files Merge in WMN_TOOLS/matter from MATTER-753-refactor-onoff-plug-apptask-to-inherit-from-base-application to silabs Squashed commit of the following: commit 2d4848a34b9eb516734b3be0494e82ace7f1318f Author: Louis-Philip Béliveau <lobelive@0018239.silabs.com> Date: Wed Sep 14 10:56:37 2022 -0400 Refactoring of onoffplug app to use the BaseApplication files
nipatel-silabs
pushed a commit
to nipatel-silabs/connectedhomeip
that referenced
this pull request
Oct 19, 2022
… BaseApplication files Merge in WMN_TOOLS/matter from MATTER-753-refactor-onoff-plug-apptask-to-inherit-from-base-application to silabs Squashed commit of the following: commit 2d4848a34b9eb516734b3be0494e82ace7f1318f Author: Louis-Philip Béliveau <lobelive@0018239.silabs.com> Date: Wed Sep 14 10:56:37 2022 -0400 Refactoring of onoffplug app to use the BaseApplication files
mkardous-silabs
referenced
this pull request
in mkardous-silabs/connectedhomeip
Oct 24, 2022
…tion files Merge in WMN_TOOLS/matter from MATTER-753-refactor-onoff-plug-apptask-to-inherit-from-base-application to silabs Squashed commit of the following: commit 2d4848a34b9eb516734b3be0494e82ace7f1318f Author: Louis-Philip Béliveau <lobelive@0018239.silabs.com> Date: Wed Sep 14 10:56:37 2022 -0400 Refactoring of onoffplug app to use the BaseApplication files
mkardous-silabs
referenced
this pull request
in mkardous-silabs/connectedhomeip
Nov 2, 2022
…tion files Merge in WMN_TOOLS/matter from MATTER-753-refactor-onoff-plug-apptask-to-inherit-from-base-application to silabs Squashed commit of the following: commit 2d4848a34b9eb516734b3be0494e82ace7f1318f Author: Louis-Philip Béliveau <lobelive@0018239.silabs.com> Date: Wed Sep 14 10:56:37 2022 -0400 Refactoring of onoffplug app to use the BaseApplication files
rerasool
referenced
this pull request
in SiliconLabs/matter
Nov 2, 2022
…tion files Merge in WMN_TOOLS/matter from MATTER-753-refactor-onoff-plug-apptask-to-inherit-from-base-application to silabs Squashed commit of the following: commit 2d4848a34b9eb516734b3be0494e82ace7f1318f Author: Louis-Philip Béliveau <lobelive@0018239.silabs.com> Date: Wed Sep 14 10:56:37 2022 -0400 Refactoring of onoffplug app to use the BaseApplication files
Thirsrin
pushed a commit
to Thirsrin/connectedhomeip
that referenced
this pull request
Jul 12, 2023
… BaseApplication files Merge in WMN_TOOLS/matter from MATTER-753-refactor-onoff-plug-apptask-to-inherit-from-base-application to silabs Squashed commit of the following: commit 2d4848a34b9eb516734b3be0494e82ace7f1318f Author: Louis-Philip Béliveau <lobelive@0018239.silabs.com> Date: Wed Sep 14 10:56:37 2022 -0400 Refactoring of onoffplug app to use the BaseApplication files
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Oct 5, 2023
… BaseApplication files Merge in WMN_TOOLS/matter from MATTER-753-refactor-onoff-plug-apptask-to-inherit-from-base-application to silabs Squashed commit of the following: commit 2d4848a34b9eb516734b3be0494e82ace7f1318f Author: Louis-Philip Béliveau <lobelive@0018239.silabs.com> Date: Wed Sep 14 10:56:37 2022 -0400 Refactoring of onoffplug app to use the BaseApplication files
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Jan 11, 2024
… BaseApplication files Merge in WMN_TOOLS/matter from MATTER-753-refactor-onoff-plug-apptask-to-inherit-from-base-application to silabs Squashed commit of the following: commit 2d4848a34b9eb516734b3be0494e82ace7f1318f Author: Louis-Philip Béliveau <lobelive@0018239.silabs.com> Date: Wed Sep 14 10:56:37 2022 -0400 Refactoring of onoffplug app to use the BaseApplication files
suveshpratapa
pushed a commit
to suveshpratapa/connectedhomeip
that referenced
this pull request
May 22, 2024
… BaseApplication files Merge in WMN_TOOLS/matter from MATTER-753-refactor-onoff-plug-apptask-to-inherit-from-base-application to silabs Squashed commit of the following: commit 2d4848a34b9eb516734b3be0494e82ace7f1318f Author: Louis-Philip Béliveau <lobelive@0018239.silabs.com> Date: Wed Sep 14 10:56:37 2022 -0400 Refactoring of onoffplug app to use the BaseApplication files
mykrupp
pushed a commit
to mykrupp/connectedhomeip
that referenced
this pull request
Jul 18, 2024
… BaseApplication files Merge in WMN_TOOLS/matter from MATTER-753-refactor-onoff-plug-apptask-to-inherit-from-base-application to silabs Squashed commit of the following: commit 2d4848a34b9eb516734b3be0494e82ace7f1318f Author: Louis-Philip Béliveau <lobelive@0018239.silabs.com> Date: Wed Sep 14 10:56:37 2022 -0400 Refactoring of onoffplug app to use the BaseApplication files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
configure.ac
didn't have platform's makefile in config file list. So it was not including it in the builds.Summary of Changes
Updated the file list. Also removed some stale references from nRF5 makefile.