Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running make does not build platform #97

Merged
merged 2 commits into from
Mar 23, 2020
Merged

Running make does not build platform #97

merged 2 commits into from
Mar 23, 2020

Conversation

pan-apple
Copy link
Contributor

Problem

configure.ac didn't have platform's makefile in config file list. So it was not including it in the builds.

Summary of Changes

Updated the file list. Also removed some stale references from nRF5 makefile.

@pan-apple
Copy link
Contributor Author

FYI @sagar-apple

hawk248
hawk248 approved these changes Mar 23, 2020
View reviewed changes
Copy link

@hawk248 hawk248 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@woody-apple woody-apple merged commit 4ec4713 into project-chip:master Mar 23, 2020
@pan-apple pan-apple deleted the nrf5-platform branch March 23, 2020 23:09
mkardous-silabs referenced this pull request in SiliconLabs/watt-sandbox Oct 6, 2022
@lpbeliveau-silabs @mkardous-silabs
Pull request SiliconLabs#97: Refactoring of onoffplug app to use the …
7d3784d 
…BaseApplication files

Merge in WMN_TOOLS/matter from MATTER-753-refactor-onoff-plug-apptask-to-inherit-from-base-application to silabs

Squashed commit of the following:

commit 2d4848a34b9eb516734b3be0494e82ace7f1318f
Author: Louis-Philip Béliveau <lobelive@0018239.silabs.com>
Date:   Wed Sep 14 10:56:37 2022 -0400

    Refactoring of onoffplug app to use the BaseApplication files
jmartinez-silabs referenced this pull request in SiliconLabs/matter Oct 13, 2022
@lpbeliveau-silabs @jmartinez-silabs
Pull request #97: Refactoring of onoffplug app to use the BaseApplica…
f16c471 
…tion files

Merge in WMN_TOOLS/matter from MATTER-753-refactor-onoff-plug-apptask-to-inherit-from-base-application to silabs

Squashed commit of the following:

commit 2d4848a34b9eb516734b3be0494e82ace7f1318f
Author: Louis-Philip Béliveau <lobelive@0018239.silabs.com>
Date:   Wed Sep 14 10:56:37 2022 -0400

    Refactoring of onoffplug app to use the BaseApplication files
nipatel-silabs pushed a commit to nipatel-silabs/connectedhomeip that referenced this pull request Oct 19, 2022
@lpbeliveau-silabs @jmartinez-silabs
Pull request project-chip#97: Refactoring of onoffplug app to use the…
3803f1a 
… BaseApplication files

Merge in WMN_TOOLS/matter from MATTER-753-refactor-onoff-plug-apptask-to-inherit-from-base-application to silabs

Squashed commit of the following:

commit 2d4848a34b9eb516734b3be0494e82ace7f1318f
Author: Louis-Philip Béliveau <lobelive@0018239.silabs.com>
Date:   Wed Sep 14 10:56:37 2022 -0400

    Refactoring of onoffplug app to use the BaseApplication files
mkardous-silabs referenced this pull request in mkardous-silabs/connectedhomeip Oct 24, 2022
@lpbeliveau-silabs @jmartinez-silabs
Pull request #97: Refactoring of onoffplug app to use the BaseApplica…
223001d 
…tion files

Merge in WMN_TOOLS/matter from MATTER-753-refactor-onoff-plug-apptask-to-inherit-from-base-application to silabs

Squashed commit of the following:

commit 2d4848a34b9eb516734b3be0494e82ace7f1318f
Author: Louis-Philip Béliveau <lobelive@0018239.silabs.com>
Date:   Wed Sep 14 10:56:37 2022 -0400

    Refactoring of onoffplug app to use the BaseApplication files
mkardous-silabs referenced this pull request in mkardous-silabs/connectedhomeip Nov 2, 2022
@lpbeliveau-silabs @jmartinez-silabs
Pull request #97: Refactoring of onoffplug app to use the BaseApplica…
30f1269 
…tion files

Merge in WMN_TOOLS/matter from MATTER-753-refactor-onoff-plug-apptask-to-inherit-from-base-application to silabs

Squashed commit of the following:

commit 2d4848a34b9eb516734b3be0494e82ace7f1318f
Author: Louis-Philip Béliveau <lobelive@0018239.silabs.com>
Date:   Wed Sep 14 10:56:37 2022 -0400

    Refactoring of onoffplug app to use the BaseApplication files
rerasool referenced this pull request in SiliconLabs/matter Nov 2, 2022
@lpbeliveau-silabs @jmartinez-silabs
Pull request #97: Refactoring of onoffplug app to use the BaseApplica…
9725e7a 
…tion files

Merge in WMN_TOOLS/matter from MATTER-753-refactor-onoff-plug-apptask-to-inherit-from-base-application to silabs

Squashed commit of the following:

commit 2d4848a34b9eb516734b3be0494e82ace7f1318f
Author: Louis-Philip Béliveau <lobelive@0018239.silabs.com>
Date:   Wed Sep 14 10:56:37 2022 -0400

    Refactoring of onoffplug app to use the BaseApplication files
Thirsrin pushed a commit to Thirsrin/connectedhomeip that referenced this pull request Jul 12, 2023
@lpbeliveau-silabs @jmartinez-silabs
Pull request project-chip#97: Refactoring of onoffplug app to use the…
8b1e477 
… BaseApplication files

Merge in WMN_TOOLS/matter from MATTER-753-refactor-onoff-plug-apptask-to-inherit-from-base-application to silabs

Squashed commit of the following:

commit 2d4848a34b9eb516734b3be0494e82ace7f1318f
Author: Louis-Philip Béliveau <lobelive@0018239.silabs.com>
Date:   Wed Sep 14 10:56:37 2022 -0400

    Refactoring of onoffplug app to use the BaseApplication files
shgutte pushed a commit to shgutte/connectedhomeip that referenced this pull request Oct 5, 2023
@lpbeliveau-silabs @jmartinez-silabs
Pull request project-chip#97: Refactoring of onoffplug app to use the…
a240384 
… BaseApplication files

Merge in WMN_TOOLS/matter from MATTER-753-refactor-onoff-plug-apptask-to-inherit-from-base-application to silabs

Squashed commit of the following:

commit 2d4848a34b9eb516734b3be0494e82ace7f1318f
Author: Louis-Philip Béliveau <lobelive@0018239.silabs.com>
Date:   Wed Sep 14 10:56:37 2022 -0400

    Refactoring of onoffplug app to use the BaseApplication files
shgutte pushed a commit to shgutte/connectedhomeip that referenced this pull request Jan 11, 2024
@lpbeliveau-silabs @jmartinez-silabs
Pull request project-chip#97: Refactoring of onoffplug app to use the…
299402c 
… BaseApplication files

Merge in WMN_TOOLS/matter from MATTER-753-refactor-onoff-plug-apptask-to-inherit-from-base-application to silabs

Squashed commit of the following:

commit 2d4848a34b9eb516734b3be0494e82ace7f1318f
Author: Louis-Philip Béliveau <lobelive@0018239.silabs.com>
Date:   Wed Sep 14 10:56:37 2022 -0400

    Refactoring of onoffplug app to use the BaseApplication files
suveshpratapa pushed a commit to suveshpratapa/connectedhomeip that referenced this pull request May 22, 2024
@lpbeliveau-silabs @jmartinez-silabs
Pull request project-chip#97: Refactoring of onoffplug app to use the…
02958b9 
… BaseApplication files

Merge in WMN_TOOLS/matter from MATTER-753-refactor-onoff-plug-apptask-to-inherit-from-base-application to silabs

Squashed commit of the following:

commit 2d4848a34b9eb516734b3be0494e82ace7f1318f
Author: Louis-Philip Béliveau <lobelive@0018239.silabs.com>
Date:   Wed Sep 14 10:56:37 2022 -0400

    Refactoring of onoffplug app to use the BaseApplication files
mykrupp pushed a commit to mykrupp/connectedhomeip that referenced this pull request Jul 18, 2024
@lpbeliveau-silabs @jmartinez-silabs
Pull request project-chip#97: Refactoring of onoffplug app to use the…
cb63f26 
… BaseApplication files

Merge in WMN_TOOLS/matter from MATTER-753-refactor-onoff-plug-apptask-to-inherit-from-base-application to silabs

Squashed commit of the following:

commit 2d4848a34b9eb516734b3be0494e82ace7f1318f
Author: Louis-Philip Béliveau <lobelive@0018239.silabs.com>
Date:   Wed Sep 14 10:56:37 2022 -0400

    Refactoring of onoffplug app to use the BaseApplication files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerickson gerickson gerickson approved these changes

@hawk248 hawk248 hawk248 approved these changes

@woody-apple woody-apple woody-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@BroderickCarlin BroderickCarlin Awaiting requested review from BroderickCarlin

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@tpmanley tpmanley Awaiting requested review from tpmanley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pan-apple @gerickson @hawk248 @woody-apple