Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mDNS shutdown #9674

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Add mDNS shutdown #9674

merged 1 commit into from
Sep 14, 2021

Conversation

kghost
Copy link
Contributor

@kghost kghost commented Sep 14, 2021

Re-submit of #9621

Problem

Hit a CI problem due to that udp endpoint in mDNS is used after udp pool has been freed.

Change overview

Add shutdown of mDNS service, shutdown the mDNS server and close udp endpoint before release udp endpoint pool

Testing

@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from 64d8f13

File Section File VM
chip-shell.elf text 16 16
chip-shell.elf rodata 8 8
chip-lock.elf text 16 16
chip-lock.elf rodata 8 8
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.debug_info,0,173
.strtab,0,153
.debug_str,0,117
.symtab,0,80
.debug_abbrev,0,79
.debug_line,0,36
.debug_frame,0,32
.debug_aranges,0,16
.debug_ranges,0,16
text,16,16
rodata,8,8
.shstrtab,0,-1
.debug_loc,0,-13

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.strtab,0,153
.debug_info,0,136
.debug_str,0,117
.symtab,0,80
.debug_abbrev,0,47
.debug_loc,0,43
.debug_line,0,41
.debug_frame,0,32
.debug_aranges,0,16
.debug_ranges,0,16
text,16,16
rodata,8,8
.shstrtab,0,-1


@kghost kghost marked this pull request as ready for review September 14, 2021 07:18
@github-actions
Copy link

Size increase report for "esp32-example-build" from 64d8f13

File Section File VM
chip-shell.elf .flash.rodata 8 8
chip-shell.elf .flash.text -24 -24
chip-lock-app.elf .flash.text 80 80
chip-temperature-measurement-app.elf .flash.text 56 56
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-bridge-app.elf and ./pull_artifact/chip-bridge-app.elf:

sections,vmsize,filesize
.debug_info,0,107
.debug_str,0,74
.debug_line,0,62
.debug_frame,0,24
.debug_aranges,0,8
.debug_ranges,0,8
.debug_loc,0,-19

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.debug_info,0,268
.debug_str,0,130
.debug_line,0,122
.strtab,0,122
.debug_abbrev,0,64
.debug_frame,0,48
.symtab,0,32
.debug_loc,0,20
.debug_aranges,0,16
.debug_ranges,0,16
[Unmapped],0,16
.flash.rodata,8,8
.shstrtab,0,2
.flash.text,-24,-24

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,110
.debug_loc,0,83
.debug_str,0,72
.debug_line,0,62
.debug_frame,0,28
.debug_abbrev,0,15
.debug_aranges,0,8
.debug_ranges,0,8
.riscv.attributes,0,-2

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize
.debug_info,0,107
.flash.text,80,80
.debug_str,0,70
.debug_line,0,62
.debug_frame,0,24
.xt.prop._ZNK4chip4SpanIhE7SubSpanEjj,0,12
.debug_aranges,0,8
.debug_ranges,0,8
.xt.lit._ZNK4chip4SpanIhE7SubSpanEjj,0,8
.debug_loc,0,1
[Unmapped],0,-80

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
.debug_info,0,107
.debug_str,0,70
.debug_line,0,62
.flash.text,56,56
.debug_frame,0,24
.debug_loc,0,21
.debug_aranges,0,8
.debug_ranges,0,8
[Unmapped],0,-56


@github-actions
Copy link

Size increase report for "gn_qpg-example-build" from 64d8f13

File Section File VM
chip-qpg6100-lighting-example.out .text 24 24
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:

sections,vmsize,filesize
.strtab,0,153
.debug_info,0,136
.debug_str,0,118
.symtab,0,80
.debug_abbrev,0,47
.debug_line,0,38
.debug_loc,0,37
.debug_frame,0,32
.text,24,24
.debug_aranges,0,16
.debug_ranges,0,16
.shstrtab,0,-1
[Unmapped],0,-24

Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'


@andy31415 andy31415 added the hotfix urgent fix needed, can bypass review label Sep 14, 2021
@andy31415
Copy link
Contributor

This is a resubmit of a already reviewed PR with a fix.

Fast-tracking it (using hotfix label)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants