Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groom SetupPayload #95

Conversation

rwalker-apple
Copy link
Contributor

Problem

SetupPayload's generation of the QRCode goes through 3 steps of
re-ordering of the information in the in-memory struct, making it harder
to verify correctness.

Summary of Changes

  • change encoding of the struct fields from from big-endian to little endian
    in the bitfieldn
  • remove the code that changes from a bitfield to a reversed array of unit16s
  • remove the reversal of the encoded string chunks
  • add a base45 decoder (for fun and for testing)

The resulting base45 string is little-endian, least significant bits in
the first character of the string.

@rwalker-apple
Copy link
Contributor Author

@bhaskar-apple
Copy link
Contributor

LGTM. Had reviewed separately in Robs fork.

@sagar-apple
Copy link
Contributor

sagar-apple commented Mar 23, 2020

add a base45 decoder (for fun and for testing)

Actually this is also part of the requirement for this library. To be able to decode a base45 string back into a SetupPayload. :)

Copy link

@hawk248 hawk248 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rwalker-apple rwalker-apple merged commit e56dd0e into project-chip:master Mar 24, 2020
@rwalker-apple rwalker-apple deleted the Groom-SetupPayload-and-add-base45decode branch March 24, 2020 18:33
mkardous-silabs referenced this pull request in SiliconLabs/watt-sandbox Oct 6, 2022
Merge in WMN_TOOLS/matter from disable_brd4187a to silabs

Squashed commit of the following:

commit 644b30bcc141ced06038110ae530b43f7ca497dd
Author: jepenven-silabs <jean-francois.penven@silabs.com>
Date:   Wed Sep 14 10:50:20 2022 -0400

    Remove BRD4187A and disable Junit for it
nipatel-silabs pushed a commit to nipatel-silabs/connectedhomeip that referenced this pull request Oct 19, 2022
Merge in WMN_TOOLS/matter from disable_brd4187a to silabs

Squashed commit of the following:

commit 644b30bcc141ced06038110ae530b43f7ca497dd
Author: jepenven-silabs <jean-francois.penven@silabs.com>
Date:   Wed Sep 14 10:50:20 2022 -0400

    Remove BRD4187A and disable Junit for it
mkardous-silabs referenced this pull request in mkardous-silabs/connectedhomeip Oct 24, 2022
Merge in WMN_TOOLS/matter from disable_brd4187a to silabs

Squashed commit of the following:

commit 644b30bcc141ced06038110ae530b43f7ca497dd
Author: jepenven-silabs <jean-francois.penven@silabs.com>
Date:   Wed Sep 14 10:50:20 2022 -0400

    Remove BRD4187A and disable Junit for it
mkardous-silabs referenced this pull request in mkardous-silabs/connectedhomeip Nov 2, 2022
Merge in WMN_TOOLS/matter from disable_brd4187a to silabs

Squashed commit of the following:

commit 644b30bcc141ced06038110ae530b43f7ca497dd
Author: jepenven-silabs <jean-francois.penven@silabs.com>
Date:   Wed Sep 14 10:50:20 2022 -0400

    Remove BRD4187A and disable Junit for it
shgutte pushed a commit to shgutte/connectedhomeip that referenced this pull request Oct 5, 2023
Merge in WMN_TOOLS/matter from disable_brd4187a to silabs

Squashed commit of the following:

commit 644b30bcc141ced06038110ae530b43f7ca497dd
Author: jepenven-silabs <jean-francois.penven@silabs.com>
Date:   Wed Sep 14 10:50:20 2022 -0400

    Remove BRD4187A and disable Junit for it
shgutte pushed a commit to shgutte/connectedhomeip that referenced this pull request Jan 11, 2024
Merge in WMN_TOOLS/matter from disable_brd4187a to silabs

Squashed commit of the following:

commit 644b30bcc141ced06038110ae530b43f7ca497dd
Author: jepenven-silabs <jean-francois.penven@silabs.com>
Date:   Wed Sep 14 10:50:20 2022 -0400

    Remove BRD4187A and disable Junit for it
mykrupp pushed a commit to mykrupp/connectedhomeip that referenced this pull request Jul 18, 2024
Merge in WMN_TOOLS/matter from disable_brd4187a to silabs

Squashed commit of the following:

commit 644b30bcc141ced06038110ae530b43f7ca497dd
Author: jepenven-silabs <jean-francois.penven@silabs.com>
Date:   Wed Sep 14 10:50:20 2022 -0400

    Remove BRD4187A and disable Junit for it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants