-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Groom SetupPayload #95
Merged
rwalker-apple
merged 7 commits into
project-chip:master
from
rwalker-apple:Groom-SetupPayload-and-add-base45decode
Mar 24, 2020
Merged
Groom SetupPayload #95
rwalker-apple
merged 7 commits into
project-chip:master
from
rwalker-apple:Groom-SetupPayload-and-add-base45decode
Mar 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwalker-apple
requested review from
anush-apple,
BroderickCarlin,
chrisdecenzo,
gerickson,
hawk248,
robszewczyk,
tpmanley and
woody-apple
as code owners
March 23, 2020 22:36
woody-apple
approved these changes
Mar 23, 2020
LGTM. Had reviewed separately in Robs fork. |
Actually this is also part of the requirement for this library. To be able to decode a base45 string back into a SetupPayload. :) |
jelderton
approved these changes
Mar 23, 2020
hawk248
approved these changes
Mar 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
BroderickCarlin
approved these changes
Mar 24, 2020
mkardous-silabs
referenced
this pull request
in SiliconLabs/watt-sandbox
Oct 6, 2022
Merge in WMN_TOOLS/matter from disable_brd4187a to silabs Squashed commit of the following: commit 644b30bcc141ced06038110ae530b43f7ca497dd Author: jepenven-silabs <jean-francois.penven@silabs.com> Date: Wed Sep 14 10:50:20 2022 -0400 Remove BRD4187A and disable Junit for it
nipatel-silabs
pushed a commit
to nipatel-silabs/connectedhomeip
that referenced
this pull request
Oct 19, 2022
Merge in WMN_TOOLS/matter from disable_brd4187a to silabs Squashed commit of the following: commit 644b30bcc141ced06038110ae530b43f7ca497dd Author: jepenven-silabs <jean-francois.penven@silabs.com> Date: Wed Sep 14 10:50:20 2022 -0400 Remove BRD4187A and disable Junit for it
mkardous-silabs
referenced
this pull request
in mkardous-silabs/connectedhomeip
Oct 24, 2022
Merge in WMN_TOOLS/matter from disable_brd4187a to silabs Squashed commit of the following: commit 644b30bcc141ced06038110ae530b43f7ca497dd Author: jepenven-silabs <jean-francois.penven@silabs.com> Date: Wed Sep 14 10:50:20 2022 -0400 Remove BRD4187A and disable Junit for it
mkardous-silabs
referenced
this pull request
in mkardous-silabs/connectedhomeip
Nov 2, 2022
Merge in WMN_TOOLS/matter from disable_brd4187a to silabs Squashed commit of the following: commit 644b30bcc141ced06038110ae530b43f7ca497dd Author: jepenven-silabs <jean-francois.penven@silabs.com> Date: Wed Sep 14 10:50:20 2022 -0400 Remove BRD4187A and disable Junit for it
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Oct 5, 2023
Merge in WMN_TOOLS/matter from disable_brd4187a to silabs Squashed commit of the following: commit 644b30bcc141ced06038110ae530b43f7ca497dd Author: jepenven-silabs <jean-francois.penven@silabs.com> Date: Wed Sep 14 10:50:20 2022 -0400 Remove BRD4187A and disable Junit for it
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Jan 11, 2024
Merge in WMN_TOOLS/matter from disable_brd4187a to silabs Squashed commit of the following: commit 644b30bcc141ced06038110ae530b43f7ca497dd Author: jepenven-silabs <jean-francois.penven@silabs.com> Date: Wed Sep 14 10:50:20 2022 -0400 Remove BRD4187A and disable Junit for it
mykrupp
pushed a commit
to mykrupp/connectedhomeip
that referenced
this pull request
Jul 18, 2024
Merge in WMN_TOOLS/matter from disable_brd4187a to silabs Squashed commit of the following: commit 644b30bcc141ced06038110ae530b43f7ca497dd Author: jepenven-silabs <jean-francois.penven@silabs.com> Date: Wed Sep 14 10:50:20 2022 -0400 Remove BRD4187A and disable Junit for it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
SetupPayload's generation of the QRCode goes through 3 steps of
re-ordering of the information in the in-memory struct, making it harder
to verify correctness.
Summary of Changes
in the bitfieldn
The resulting base45 string is little-endian, least significant bits in
the first character of the string.