-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close BLE connections after the Operational Network is provisioned on a Node #9379
Merged
woody-apple
merged 1 commit into
project-chip:master
from
sagar-apple:close_ble_connections
Sep 1, 2021
Merged
Close BLE connections after the Operational Network is provisioned on a Node #9379
woody-apple
merged 1 commit into
project-chip:master
from
sagar-apple:close_ble_connections
Sep 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda,
mspang,
saurabhst,
selissia and
woody-apple
August 31, 2021 22:53
saurabhst
approved these changes
Aug 31, 2021
sagar-apple
force-pushed
the
close_ble_connections
branch
from
August 31, 2021 22:55
5b2caeb
to
43ed868
Compare
woody-apple
approved these changes
Aug 31, 2021
@LuDuda ? |
hawk248
approved these changes
Sep 1, 2021
chrisdecenzo
approved these changes
Sep 1, 2021
Size increase report for "esp32-example-build" from 70fe2e7
Full report output
|
Size increase report for "nrfconnect-example-build" from 70fe2e7
Full report output
|
Size increase report for "gn_qpg-example-build" from 70fe2e7
Full report output
|
gjc13
added a commit
to gjc13/connectedhomeip
that referenced
this pull request
Sep 1, 2021
…ioned on a Node (project-chip#9379)" This reverts commit 6a6446f.
mkardous-silabs
pushed a commit
to mkardous-silabs/connectedhomeip
that referenced
this pull request
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Nodes should terminate their BLE connections after they have been provisioned on the operational network.
Our current implementation leaves the BLE connection alive after commissioning is complete.
This can prevent multiple commissioners on the same machine from being able to operate independently.
Change overview
Close all BLE Connections after the operational network is provisioned.
Testing
Tested that two iOS apps(changed the bundleID of CHIPTool to install it twice) are able to pair with accessories independent of each other. Tested with chip-tool on macOS as well.