Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close BLE connections after the Operational Network is provisioned on a Node #9379

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

sagar-apple
Copy link
Contributor

@sagar-apple sagar-apple commented Aug 31, 2021

Problem

Nodes should terminate their BLE connections after they have been provisioned on the operational network.

Our current implementation leaves the BLE connection alive after commissioning is complete.
This can prevent multiple commissioners on the same machine from being able to operate independently.

Change overview

Close all BLE Connections after the operational network is provisioned.

Testing

  • If manually tested, what platforms controller and device platforms were manually tested, and how?
    Tested that two iOS apps(changed the bundleID of CHIPTool to install it twice) are able to pair with accessories independent of each other. Tested with chip-tool on macOS as well.

@sagar-apple sagar-apple force-pushed the close_ble_connections branch from 5b2caeb to 43ed868 Compare August 31, 2021 22:55
@woody-apple
Copy link
Contributor

@woody-apple
Copy link
Contributor

@LuDuda ?

@github-actions
Copy link

github-actions bot commented Sep 1, 2021

Size increase report for "esp32-example-build" from 70fe2e7

File Section File VM
chip-all-clusters-app.elf .flash.text 132 132
chip-all-clusters-app.elf .flash.rodata 24 24
chip-all-clusters-app.elf .dram0.bss 0 -8
chip-all-clusters-app.elf .dram0.heap_start 0 -8
chip-lock-app.elf .flash.text 96 96
chip-lock-app.elf .flash.rodata 32 32
chip-ipv6only-app.elf .flash.text -172 -172
chip-temperature-measurement-app.elf .flash.text 100 100
chip-temperature-measurement-app.elf .flash.rodata 24 24
chip-temperature-measurement-app.elf .dram0.bss 0 8
chip-bridge-app.elf .flash.text 100 100
chip-bridge-app.elf .flash.rodata 24 24
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,6662
.debug_line,0,253
.flash.text,132,132
.strtab,0,82
.debug_abbrev,0,51
.symtab,0,32
.flash.rodata,24,24
.debug_frame,0,8
.debug_loc,0,7
.riscv.attributes,0,-1
.shstrtab,0,-2
.debug_ranges,0,-8
.dram0.bss,-8,0
.dram0.heap_start,-8,0
[Unmapped],0,-156

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize
.debug_info,0,6701
.debug_line,0,329
.flash.text,96,96
.strtab,0,82
.debug_abbrev,0,59
.debug_loc,0,56
.flash.rodata,32,32
.symtab,0,32
.debug_ranges,0,24
.shstrtab,0,2
.debug_str,0,-1
[Unmapped],0,-128

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize
.flash.text,-172,-172
[Unmapped],0,-3924

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
.debug_info,0,6700
.debug_line,0,335
.flash.text,100,100
.strtab,0,82
.debug_loc,0,65
.debug_abbrev,0,59
.symtab,0,32
.debug_ranges,0,24
.flash.rodata,24,24
.dram0.bss,8,0
.shstrtab,0,2
.debug_str,0,1
[Unmapped],0,-124

Comparing ./master_artifact/chip-bridge-app.elf and ./pull_artifact/chip-bridge-app.elf:

sections,vmsize,filesize
.debug_info,0,6700
.debug_line,0,329
.flash.text,100,100
.strtab,0,82
.debug_abbrev,0,59
.debug_loc,0,57
.symtab,0,32
.debug_ranges,0,24
.flash.rodata,24,24
.shstrtab,0,2
.debug_str,0,-1
[Unmapped],0,-124

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize


@github-actions
Copy link

github-actions bot commented Sep 1, 2021

Size increase report for "nrfconnect-example-build" from 70fe2e7

File Section File VM
chip-lock.elf text 92 92
chip-lock.elf rodata 24 28
chip-lock.elf device_handles 4 4
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_info,0,5723
.debug_line,0,278
text,92,92
.debug_abbrev,0,91
.strtab,0,82
.symtab,0,80
.debug_loc,0,28
rodata,28,24
.debug_ranges,0,8
device_handles,4,4
.shstrtab,0,-2


@github-actions
Copy link

github-actions bot commented Sep 1, 2021

Size increase report for "gn_qpg-example-build" from 70fe2e7

File Section File VM
chip-qpg6100-lighting-example.out .text 124 124
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'

Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:

sections,vmsize,filesize
.debug_info,0,5723
.debug_line,0,274
.text,124,124
.strtab,0,82
.symtab,0,80
.debug_abbrev,0,67
.debug_loc,0,35
.debug_ranges,0,8
.shstrtab,0,2
.debug_str,0,-3
[Unmapped],0,-124


@woody-apple woody-apple merged commit 6a6446f into project-chip:master Sep 1, 2021
@sagar-apple sagar-apple deleted the close_ble_connections branch September 1, 2021 01:08
gjc13 added a commit to gjc13/connectedhomeip that referenced this pull request Sep 1, 2021
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants