Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ResetCounts command for Network Diagnostics Cluster #8679

Merged
merged 1 commit into from
Aug 3, 2021
Merged

Implement ResetCounts command for Network Diagnostics Cluster #8679

merged 1 commit into from
Aug 3, 2021

Conversation

yufengwangca
Copy link
Contributor

@yufengwangca yufengwangca commented Jul 28, 2021

Problem

What is being fixed? Examples:
*Attribute Accessory helper APIs have been merged, now we can implement the missing ResetCounts command for Thread/WiFi/Ethernet Network Diagnostics Cluster

Change overview

Implement ResetCounts command for Thread/WiFi/Ethernet Network Diagnostics Cluster

Testing

How was this tested? (at least one bullet point required)

  1. Reset thread network diagnostic counts
    ./chip-tool threadnetworkdiagnostics reset-counts 0
    Confirm attribute OverrunCount is set to 0

  2. Reset wifi network diagnostic counts
    ./chip-tool wifinetworkdiagnostics reset-counts 0
    Confirm reception of this command SHALL reset the following attributes to 0:
    • BeaconLostCount
    • BeaconRxCount
    • PacketMulticastRxCount
    • PacketMulticastTxCount
    • PacketUnicastRxCount
    • PacketUnicastTxCount
    • OverrunCount

  3. Reset ethernet network diagnostic counts
    ./chip-tool ethernetnetworkdiagnostics reset-counts 0
    Confirm reception of this command SHALL reset the following attributes to 0:
    • PacketRxCount
    • PacketTxCount
    • TxErrCount
    • CollisionCount
    • OverrunCount

@github-actions
Copy link

Size increase report for "esp32-example-build" from b77bfb0

File Section File VM
chip-shell.elf .flash.text -20 -20
chip-all-clusters-app.elf .flash_rodata_dummy 0 65536
chip-all-clusters-app.elf .flash.text 716 716
chip-all-clusters-app.elf .flash.rodata 488 488
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
[Unmapped],0,20
.flash.text,-20,-20

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.flash_rodata_dummy,65536,0
[LOAD #0 [RW]],0,65536
[Unmapped],0,2892
.debug_line,0,1515
.debug_info,0,1298
.strtab,0,1078
.flash.text,716,716
.flash.rodata,488,488
.debug_loc,0,210
.symtab,0,208
.debug_abbrev,0,164
.debug_frame,0,28
.shstrtab,0,2
.riscv.attributes,0,1

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize


@github-actions
Copy link

Size increase report for "gn_qpg-example-build" from b77bfb0

File Section File VM
chip-qpg6100-lighting-example.out .text 1096 1096
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'

Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:

sections,vmsize,filesize
.debug_info,0,242240
.debug_str,0,165433
.debug_loc,0,125531
.debug_line,0,63950
.debug_frame,0,37656
.debug_aranges,0,12568
.debug_ranges,0,12552
.debug_abbrev,0,2494
.text,1096,1096
.strtab,0,1092
.symtab,0,512
[Unmapped],0,-1096


@yufengwangca
Copy link
Contributor Author

@yufengwangca yufengwangca added this to the Test Event 5 milestone Aug 2, 2021
@andy31415 andy31415 merged commit 7dd4361 into project-chip:master Aug 3, 2021
@yufengwangca yufengwangca deleted the pr/cluster/resetcounts branch August 3, 2021 18:22
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the ResetCounts in the platform layer.
5 participants