-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ResetCounts command for Network Diagnostics Cluster #8679
Merged
andy31415
merged 1 commit into
project-chip:master
from
yufengwangca:pr/cluster/resetcounts
Aug 3, 2021
Merged
Implement ResetCounts command for Network Diagnostics Cluster #8679
andy31415
merged 1 commit into
project-chip:master
from
yufengwangca:pr/cluster/resetcounts
Aug 3, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs and
msandstedt
July 28, 2021 14:55
bzbarsky-apple
approved these changes
Jul 29, 2021
msandstedt
approved these changes
Jul 29, 2021
Size increase report for "esp32-example-build" from b77bfb0
Full report output
|
Size increase report for "gn_qpg-example-build" from b77bfb0
Full report output
|
andy31415
approved these changes
Aug 3, 2021
pullapprove
bot
added
review - approved
and removed
review - pending
technical review - DONE
labels
Aug 3, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
*Attribute Accessory helper APIs have been merged, now we can implement the missing ResetCounts command for Thread/WiFi/Ethernet Network Diagnostics Cluster
Change overview
Implement ResetCounts command for Thread/WiFi/Ethernet Network Diagnostics Cluster
Testing
How was this tested? (at least one bullet point required)
Reset thread network diagnostic counts
./chip-tool threadnetworkdiagnostics reset-counts 0
Confirm attribute OverrunCount is set to 0
Reset wifi network diagnostic counts
./chip-tool wifinetworkdiagnostics reset-counts 0
Confirm reception of this command SHALL reset the following attributes to 0:
• BeaconLostCount
• BeaconRxCount
• PacketMulticastRxCount
• PacketMulticastTxCount
• PacketUnicastRxCount
• PacketUnicastTxCount
• OverrunCount
Reset ethernet network diagnostic counts
./chip-tool ethernetnetworkdiagnostics reset-counts 0
Confirm reception of this command SHALL reset the following attributes to 0:
• PacketRxCount
• PacketTxCount
• TxErrCount
• CollisionCount
• OverrunCount