-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OpenThread] Optimize memory usage of DNS client #8614
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the worst-case scenario, the DNS client must correctly handle a commissionable node service which contains a TXT entry with key "PI" and a pairing instruction up to 128 characters. Change the method of allocating memory for the resolved/discovered services to allow such long TXT entries yet not to consume too much memory on stack.
pullapprove
bot
requested review from
bzbarsky-apple,
chrisdecenzo,
hawk248,
jepenven-silabs,
LuDuda,
msandstedt and
yufengwangca
July 24, 2021 06:50
Size increase report for "esp32-example-build" from 762a204
Full report output
|
Size increase report for "nrfconnect-example-build" from 762a204
Full report output
|
LuDuda
approved these changes
Jul 24, 2021
msandstedt
approved these changes
Jul 26, 2021
saurabhst
approved these changes
Jul 26, 2021
woody-apple
approved these changes
Jul 26, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
In the worst-case scenario, the DNS client must correctly handle a commissionable node service which contains a TXT entry with key "PI" and a pairing instruction up to 128 characters. Change the method of allocating memory for the resolved/discovered services to allow such long TXT entries yet not to consume too much memory on stack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In the worst-case scenario, the DNS client must correctly handle a commissionable node service which contains
a TXT entry with key "PI" and a pairing instruction up to 128 characters. Current DNS client implementation for OpenThread does not support such long TXT entries to limit the stack usage.
Change overview
Change the method of allocating memory for the resolved/discovered services to allow long TXT entries, yet not to consume too much memory on stack.
Fixes #8467.
Testing
Tested along with #8454 that nRF Connect Lock can both advertise and discover (with
matter dns browse
shell command) a node with the longest possible pairing instruction.