Re-enable the TestCluster bits of the Tests job. #8517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs,
msandstedt and
woody-apple
saurabhst
approved these changes
Jul 20, 2021
These got disabled by accident because that filename does not have a '_' in it.
bzbarsky-apple
force-pushed
the
fix-test-job
branch
from
b0d97ac
to
f176890
Compare
yufengwangca
approved these changes
Jul 20, 2021
|
@woody-apple @Damian-Nordic @jepenven-silabs @jelderton @jmartinez-silabs @mspang @LuDuda Please take a look? |
msandstedt
approved these changes
Jul 21, 2021
jmartinez-silabs
approved these changes
Jul 21, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
These got disabled by accident because that filename does not have a '_' in it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These got disabled by accident because that filename does not have a '_' in it.
Problem
We no longer run TestCluster tests in the "Tests" CI (we do still run it in the Darwin CI).
Change overview
Run TestCluster tests again.
Testing
Manually verified that if I add a failing TestCluster test the job still passes without this PR and fails with it.