Fix casing for "chip" in comments #85

pan-apple · 2020-03-20T22:35:06Z

Problem

Code has mixed use of Chip, CHIP and chip in the comments

Summary of Changes

Use CHIP in comments.

gerickson

Overall, this looks good; however, the prevailing coding style for method and free function calls is <lower Case><Captial Case><Capital Case>. I'd recommend that we preserve that.

The other option is to transition to the other advocated styles of "a"<Capital Case><Captial Case><Capital Case> for arguments or "i"<Capital Case><Captial Case><Capital Case> for input arguments, "o"<Capital Case><Captial Case><Capital Case> for output arguments, and "io"<Capital Case><Captial Case><Capital Case> for input/output arguments.

pan-apple · 2020-03-20T23:06:01Z

Overall, this looks good; however, the prevailing coding style for method and free function calls is <lower Case><Captial Case><Capital Case>. I'd recommend that we preserve that.

The other option is to transition to the other advocated styles of "a"<Capital Case><Captial Case><Capital Case> for arguments or "i"<Capital Case><Captial Case><Capital Case> for input arguments, "o"<Capital Case><Captial Case><Capital Case> for output arguments, and "io"<Capital Case><Captial Case><Capital Case> for input/output arguments.

@gerickson , I agree with the coding style you mentioned. Are you referring to a specific change in the current PR, as I am unable to spot it? Or, is it a more general comment?

gerickson · 2020-03-20T23:10:23Z

Overall, this looks good; however, the prevailing coding style for method and free function calls is <lower Case><Captial Case><Capital Case>. I'd recommend that we preserve that.
The other option is to transition to the other advocated styles of "a"<Capital Case><Captial Case><Capital Case> for arguments or "i"<Capital Case><Captial Case><Capital Case> for input arguments, "o"<Capital Case><Captial Case><Capital Case> for output arguments, and "io"<Capital Case><Captial Case><Capital Case> for input/output arguments.

@gerickson , I agree with the coding style you mentioned. Are you referring to a specific change in the current PR, as I am unable to spot it? Or, is it a more general comment?

There were a healthy number of instances of something to the effect of (const char *fooBar, uint8_t chipSomething, Type &dogCow) that are now (const char *fooBar, uint8_t ChipSomething, Type &dogCow) where "Chip" is now antipattern for the argument style.

gerickson · 2020-03-20T23:11:37Z

src/ble/BleUUID.cpp

                                        0x00, 0x00, 0xFE, 0xAF, 0x00, 0x00, 0x10, 0x00, 0x80, 0x00, 0x00, 0x80, 0x5F, 0x9B, 0x34,
                                        0xFB } };

-bool UUIDsMatch(const chipBleUUID * idOne, const chipBleUUID * idTwo)
+bool UUIDsMatch(const ChipBleUUID * idOne, const ChipBleUUID * idTwo)


See #85 (review)

@gerickson chipBleUUID is the data type, not the parameter. I think it used to be WeaveBleUUID

I looked too quickly, so it is.

gerickson · 2020-03-20T23:12:22Z

src/ble/BleLayer.cpp

    }

    return err;
 }

-bool BleLayer::HandleWriteReceived(BLE_CONNECTION_OBJECT connObj, const chipBleUUID * svcId, const chipBleUUID * charId,
+bool BleLayer::HandleWriteReceived(BLE_CONNECTION_OBJECT connObj, const ChipBleUUID * svcId, const ChipBleUUID * charId,


See #85 (review)

gerickson · 2020-03-20T23:13:01Z

Overall, this looks good; however, the prevailing coding style for method and free function calls is <lower Case><Captial Case><Capital Case>. I'd recommend that we preserve that.
The other option is to transition to the other advocated styles of "a"<Capital Case><Captial Case><Capital Case> for arguments or "i"<Capital Case><Captial Case><Capital Case> for input arguments, "o"<Capital Case><Captial Case><Capital Case> for output arguments, and "io"<Capital Case><Captial Case><Capital Case> for input/output arguments.

@gerickson , I agree with the coding style you mentioned. Are you referring to a specific change in the current PR, as I am unable to spot it? Or, is it a more general comment?

There were a healthy number of instances of something to the effect of (const char *fooBar, uint8_t chipSomething, Type &dogCow) that are now (const char *fooBar, uint8_t ChipSomething, Type &dogCow) where "Chip" is now antipattern for the argument style.

I flagged a few of them for reference.

gerickson · 2020-03-20T23:19:39Z

Overall, this looks good; however, the prevailing coding style for method and free function calls is <lower Case><Captial Case><Capital Case>. I'd recommend that we preserve that.
The other option is to transition to the other advocated styles of "a"<Capital Case><Captial Case><Capital Case> for arguments or "i"<Capital Case><Captial Case><Capital Case> for input arguments, "o"<Capital Case><Captial Case><Capital Case> for output arguments, and "io"<Capital Case><Captial Case><Capital Case> for input/output arguments.

@gerickson , I agree with the coding style you mentioned. Are you referring to a specific change in the current PR, as I am unable to spot it? Or, is it a more general comment?

There were a healthy number of instances of something to the effect of (const char *fooBar, uint8_t chipSomething, Type &dogCow) that are now (const char *fooBar, uint8_t ChipSomething, Type &dogCow) where "Chip" is now antipattern for the argument style.

I flagged a few of them for reference.

My apologies; I scanned through too quickly.

pan-apple · 2020-03-20T23:21:14Z

Overall, this looks good; however, the prevailing coding style for method and free function calls is <lower Case><Captial Case><Capital Case>. I'd recommend that we preserve that.
The other option is to transition to the other advocated styles of "a"<Capital Case><Captial Case><Capital Case> for arguments or "i"<Capital Case><Captial Case><Capital Case> for input arguments, "o"<Capital Case><Captial Case><Capital Case> for output arguments, and "io"<Capital Case><Captial Case><Capital Case> for input/output arguments.

@gerickson , I agree with the coding style you mentioned. Are you referring to a specific change in the current PR, as I am unable to spot it? Or, is it a more general comment?

There were a healthy number of instances of something to the effect of (const char *fooBar, uint8_t chipSomething, Type &dogCow) that are now (const char *fooBar, uint8_t ChipSomething, Type &dogCow) where "Chip" is now antipattern for the argument style.

I flagged a few of them for reference.

My apologies; I scanned through too quickly.

No worries. Thank you for reviewing it!

woody-apple · 2020-03-23T18:07:27Z

@hawk248 @BroderickCarlin ?

hawk248

👍

Switch to use Mbed OS 6.7.0 in chip-build-mbed-os image.

Merge in WMN_TOOLS/matter from remove_openthread_ci_scripts to silabs Squashed commit of the following: commit 17a94f1e8eb2560a10d7eee409582596b48d72a6 Author: jepenven-silabs <jean-francois.penven@silabs.com> Date: Thu Sep 8 14:31:47 2022 -0400 fix typo commit 9a44fa8cba80bada7c35673427032b6ebea18f8d Author: jepenven-silabs <jean-francois.penven@silabs.com> Date: Thu Sep 8 12:00:47 2022 -0400 Fix stash commit 0362349ec838c52b43a5d26fe208018bf750535b Author: Yulina Shu <Yulina.Shu@silabs.com> Date: Wed Sep 7 23:47:57 2022 +0000 use build-farm-large for big job commit c5660b1a3d78f1e71b8d517682ee4137ed5e9221 Author: jepenven-silabs <jean-francois.penven@silabs.com> Date: Thu Sep 8 08:33:15 2022 -0400 Remove OpenThread python scripts build

Fix casing for "chip" in comments

43c9c68

pan-apple requested review from anush-apple, BroderickCarlin, chrisdecenzo, gerickson, hawk248, robszewczyk, tpmanley and woody-apple as code owners March 20, 2020 22:35

gerickson suggested changes Mar 20, 2020

View reviewed changes

gerickson reviewed Mar 20, 2020

View reviewed changes

gerickson approved these changes Mar 20, 2020

View reviewed changes

woody-apple approved these changes Mar 23, 2020

View reviewed changes

hawk248 approved these changes Mar 23, 2020

View reviewed changes

woody-apple merged commit b2436cc into project-chip:master Mar 23, 2020

fkjagodzinski pushed a commit to fkjagodzinski/connectedhomeip that referenced this pull request Mar 2, 2021

Merge pull request project-chip#85 from lukgni/switch_to_mbed_6_7_0

31ea476

Switch to use Mbed OS 6.7.0 in chip-build-mbed-os image.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix casing for "chip" in comments #85

Fix casing for "chip" in comments #85

pan-apple commented Mar 20, 2020

gerickson left a comment •

edited

Loading

pan-apple commented Mar 20, 2020

gerickson commented Mar 20, 2020

gerickson Mar 20, 2020

pan-apple Mar 20, 2020 •

edited

Loading

gerickson Mar 20, 2020 •

edited

Loading

gerickson Mar 20, 2020

gerickson commented Mar 20, 2020

gerickson commented Mar 20, 2020

pan-apple commented Mar 20, 2020

woody-apple commented Mar 23, 2020

hawk248 left a comment

Fix casing for "chip" in comments #85

Fix casing for "chip" in comments #85

Conversation

pan-apple commented Mar 20, 2020

Problem

Summary of Changes

gerickson left a comment • edited Loading

Choose a reason for hiding this comment

pan-apple commented Mar 20, 2020

gerickson commented Mar 20, 2020

gerickson Mar 20, 2020

Choose a reason for hiding this comment

pan-apple Mar 20, 2020 • edited Loading

Choose a reason for hiding this comment

gerickson Mar 20, 2020 • edited Loading

Choose a reason for hiding this comment

gerickson Mar 20, 2020

Choose a reason for hiding this comment

gerickson commented Mar 20, 2020

gerickson commented Mar 20, 2020

pan-apple commented Mar 20, 2020

woody-apple commented Mar 23, 2020

hawk248 left a comment

Choose a reason for hiding this comment

gerickson left a comment •

edited

Loading

pan-apple Mar 20, 2020 •

edited

Loading

gerickson Mar 20, 2020 •

edited

Loading