-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for scripts/build test failure #8499
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sweetymhaiske
force-pushed
the
build_fixes
branch
from
July 20, 2021 05:58
edb2d90
to
6661c9e
Compare
pullapprove
bot
requested review from
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs,
msandstedt,
woody-apple and
yufengwangca
July 20, 2021 05:58
Size increase report for "esp32-example-build" from d24b3c0
Full report output
|
dhrishi
approved these changes
Jul 20, 2021
Damian-Nordic
approved these changes
Jul 20, 2021
bzbarsky-apple
approved these changes
Jul 20, 2021
tcarmelveilleux
approved these changes
Jul 20, 2021
msandstedt
approved these changes
Jul 20, 2021
drempelg
pushed a commit
to drempelg/connectedhomeip
that referenced
this pull request
Jul 20, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
scripts/build/expected_all_platform_commands.txt
usessdkconfig_devkitc.defaults
, which is now deprecated here (ESP32: Optimize the time taken by esp32 workflows #8409)Change overview
Replace the occurrence of
sdkconfig_devkitc.defaults
withskdconfig.defaults
Testing
Ran
gn_build.sh