Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Add command for closing an open connection #8430

Merged
merged 2 commits into from
Jul 16, 2021

Conversation

Damian-Nordic
Copy link
Contributor

Problem

Currently, the CHIP stack is not able to automatically recover an open CASE session in certain circumstances such as a device
reboot.

Change overview

Add a command for closing an open session on the controller side so that the connection can be started from scratch when necessary.

Testing

Tested manually with nRF Connect Lock:

  • commissioned the device
  • rebooted the device
  • run "close-session "
  • sent a few ZCL commands to verify that another CASE session was established and the communication got back to normal.

src/controller/CHIPDevice.h Outdated Show resolved Hide resolved
@yunhanw-google
Copy link
Contributor

/rebase

Currently, the CHIP stack is not able to recover an open
CASE session in certain circumstances such as a device
reboot. Add a command for closing an open session on the
controller side so that the connection can be started from
scratch when necessary.
@github-actions
Copy link

Size increase report for "esp32-example-build" from 110ef41

File Section File VM
chip-temperature-measurement-app.elf .flash.text 60 60
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
[Unmapped],0,4036
.flash.text,60,60

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize


Copy link
Contributor

@LuDuda LuDuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Could you update the README.md with the new command? Alternatively, if it's expensive to maintain, instruct to call the help command or sth..

@yunhanw-google
Copy link
Contributor

Anyone merge this one?

@mspang mspang merged commit 88cd766 into project-chip:master Jul 16, 2021
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
* [python] Add command for closing an open connection

Currently, the CHIP stack is not able to recover an open
CASE session in certain circumstances such as a device
reboot. Add a command for closing an open session on the
controller side so that the connection can be started from
scratch when necessary.

* Update README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants