Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix leftover from #8236 and make BufferReader/Writer support Span #8408

Merged
merged 14 commits into from
Jul 20, 2021
Merged

Fix leftover from #8236 and make BufferReader/Writer support Span #8408

merged 14 commits into from
Jul 20, 2021

Commits on Jul 15, 2021

  1. Fix leftover from project-chip#8236 and make BufferReader/Writer supp… 

    …ort Span

- Fix leftover nits from @bzbarsky-apple's review of project-chip#8236
- In order to add span support cleanly, added Span support to
  Reader and BufferWriter, and fixed all necessary breakage.

Testing done: pass all unit tests and CASE cert tests
    @tcarmelveilleux
    tcarmelveilleux committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    672ddc0 View commit details
    Browse the repository at this point in the history

  2. Fix mbedTLS usage of EcdsaAsn1SignatureToRaw

    @tcarmelveilleux
    tcarmelveilleux committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    dd7175c View commit details
    Browse the repository at this point in the history

  3. Apply review comments from @bzbarsky-apple

    @tcarmelveilleux
    tcarmelveilleux committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    cd0206b View commit details
    Browse the repository at this point in the history

  4. Use some span reassign instead of out_size ref

    @tcarmelveilleux
    tcarmelveilleux committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    0265f1a View commit details
    Browse the repository at this point in the history

  5. Restyled by clang-format

    @restyled-commits
    restyled-commits committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    7d526fe View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary nullptr checks handled by Span::size()

    @tcarmelveilleux
    tcarmelveilleux committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    0c966f9 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2021

  1. Improve IntegerToDer test coverage 

    - Assign to output spans
- Use new span function for validity checks (`is_span_usable`)
- Replace an untested CHIPCert.cpp usage with tested version
    @tcarmelveilleux
    tcarmelveilleux committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    04be03c View commit details
    Browse the repository at this point in the history

  2. Add is_span_usable() tests

    @tcarmelveilleux
    tcarmelveilleux committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    2b723d7 View commit details
    Browse the repository at this point in the history

  3. Restyled by clang-format

    @restyled-commits
    restyled-commits committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    8cd1ec5 View commit details
    Browse the repository at this point in the history

  4. Grammar fix to kick CI

    @tcarmelveilleux
    tcarmelveilleux committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    1f9bea5 View commit details
    Browse the repository at this point in the history

  5. Commit forgotten removal of obsolete ConvertIntegerRawToDER from CHIP… 

    …Cert.h
    @tcarmelveilleux
    tcarmelveilleux committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    a200593 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2021

  1. Apply review comments from @mspang

    @tcarmelveilleux
    tcarmelveilleux committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    5e273d0 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2021

  1. Fix clang

    @tcarmelveilleux
    tcarmelveilleux committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    1ae2f64 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into fixes/nits-from-8236

    @tcarmelveilleux
    tcarmelveilleux committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    a646f5e View commit details
    Browse the repository at this point in the history