-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix leftover from #8236 and make BufferReader/Writer support Span #8408
Merged
bzbarsky-apple
merged 14 commits into
project-chip:master
from
tcarmelveilleux:fixes/nits-from-8236
Jul 20, 2021
Merged
Fix leftover from #8236 and make BufferReader/Writer support Span #8408
bzbarsky-apple
merged 14 commits into
project-chip:master
from
tcarmelveilleux:fixes/nits-from-8236
Jul 20, 2021
Commits on Jul 15, 2021
-
Fix leftover from project-chip#8236 and make BufferReader/Writer supp…
…ort Span - Fix leftover nits from @bzbarsky-apple's review of project-chip#8236 - In order to add span support cleanly, added Span support to Reader and BufferWriter, and fixed all necessary breakage. Testing done: pass all unit tests and CASE cert tests
Configuration menu - View commit details
-
Copy full SHA for 672ddc0 - Browse repository at this point
Copy the full SHA 672ddc0View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd7175c - Browse repository at this point
Copy the full SHA dd7175cView commit details -
Configuration menu - View commit details
-
Copy full SHA for cd0206b - Browse repository at this point
Copy the full SHA cd0206bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0265f1a - Browse repository at this point
Copy the full SHA 0265f1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d526fe - Browse repository at this point
Copy the full SHA 7d526feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c966f9 - Browse repository at this point
Copy the full SHA 0c966f9View commit details
Commits on Jul 16, 2021
-
Improve IntegerToDer test coverage
- Assign to output spans - Use new span function for validity checks (`is_span_usable`) - Replace an untested CHIPCert.cpp usage with tested version
Configuration menu - View commit details
-
Copy full SHA for 04be03c - Browse repository at this point
Copy the full SHA 04be03cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b723d7 - Browse repository at this point
Copy the full SHA 2b723d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8cd1ec5 - Browse repository at this point
Copy the full SHA 8cd1ec5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f9bea5 - Browse repository at this point
Copy the full SHA 1f9bea5View commit details -
Configuration menu - View commit details
-
Copy full SHA for a200593 - Browse repository at this point
Copy the full SHA a200593View commit details
Commits on Jul 19, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 5e273d0 - Browse repository at this point
Copy the full SHA 5e273d0View commit details
Commits on Jul 20, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 1ae2f64 - Browse repository at this point
Copy the full SHA 1ae2f64View commit details -
Configuration menu - View commit details
-
Copy full SHA for a646f5e - Browse repository at this point
Copy the full SHA a646f5eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.