-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for esp32 flashing_script #8358
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cecille
changed the title
[WIP] Draft changes to esp32 flashing_script
Fixes for esp32 flashing_script
Jul 16, 2021
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda,
saurabhst and
woody-apple
July 16, 2021 11:43
cecille
requested review from
sweetymhaiske
and removed request for
LuDuda,
saurabhst,
woody-apple,
chrisdecenzo,
jelderton and
jmartinez-silabs
July 16, 2021 11:43
pullapprove
bot
requested review from
chrisdecenzo,
jelderton and
jmartinez-silabs
July 16, 2021 11:43
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda,
saurabhst and
woody-apple
July 16, 2021 11:43
Size increase report for "esp32-example-build" from 110ef41
Full report output
|
mspang
reviewed
Jul 16, 2021
Also adding a missed piece to the build-all-clusters-app.sh script.
mspang
reviewed
Jul 19, 2021
mspang
approved these changes
Jul 20, 2021
@cecille Can you please update the README (Remove setting of baud value explicitly)? |
sweetymhaiske
approved these changes
Jul 20, 2021
caveat emptor.
mspang
approved these changes
Jul 20, 2021
saurabhst
approved these changes
Jul 21, 2021
jmartinez-silabs
approved these changes
Jul 21, 2021
mspang
pushed a commit
that referenced
this pull request
Aug 12, 2021
* Draft changes to esp32 flash_script * Fix board type * Fix pigweed. * Address review comments Also adding a missed piece to the build-all-clusters-app.sh script. * Update readme files. * Remove warning on ESPPORT not set. caveat emptor. (cherry picked from commit 354fc86)
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
* Draft changes to esp32 flash_script * Fix board type * Fix pigweed. * Address review comments Also adding a missed piece to the build-all-clusters-app.sh script. * Update readme files. * Remove warning on ESPPORT not set. caveat emptor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Flash script for ESP32 throws an exception. Also, cmake code is duplicated in multiple projects.
Change overview
Testing