Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reset ExchangeContext's "waiting to send" state when sending standalone ack. #8298

Merged

Conversation

bzbarsky-apple
Copy link
Contributor

This state is meant to track app-level sends, and standalone acks are
not app-level.

Problem

Standalone acks are being treated as "message send", necessitating workarounds in other places (e.g. in exchange context closing logic).

Change overview

Be more careful about what we treat as a "message send" so we can avoid the workarounds in the future.

Testing

Passes CI. Will keep doing that as the workarounds are removed.

…andalone ack.

This state is meant to track app-level sends, and standalone acks are
not app-level.
@github-actions
Copy link

Size increase report for "gn_qpg-example-build" from a70c659

File Section File VM
chip-qpg6100-lighting-example.out .text 16 16
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'

Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:

sections,vmsize,filesize
.debug_info,0,3442
.debug_loc,0,72
.debug_line,0,49
.debug_str,0,33
.debug_abbrev,0,16
.debug_ranges,0,16
.text,16,16
[Unmapped],0,-16


@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from a70c659

File Section File VM
chip-lock.elf text 16 16
chip-shell.elf text 12 12
chip-shell.elf device_handles -12 -12
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_info,0,3406
.debug_loc,0,73
.debug_line,0,50
.debug_str,0,31
.debug_abbrev,0,16
.debug_ranges,0,16
text,16,16

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.debug_info,0,814
.debug_loc,0,73
.debug_line,0,50
.debug_str,0,31
.debug_abbrev,0,16
.debug_ranges,0,16
text,12,12
device_handles,-12,-12


@github-actions
Copy link

Size increase report for "esp32-example-build" from a70c659

File Section File VM
chip-shell.elf .flash.text 24 24
chip-all-clusters-app.elf .flash.text 24 24
chip-lock-app.elf .flash.text -40 -40
chip-temperature-measurement-app.elf .flash.text -36 -36
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.debug_info,0,819
.debug_line,0,115
.debug_loc,0,89
.debug_abbrev,0,36
.debug_str,0,29
.flash.text,24,24
[Unmapped],0,-24

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,4095
.debug_line,0,115
.debug_loc,0,93
.debug_abbrev,0,36
.debug_str,0,33
.flash.text,24,24
[Unmapped],0,-24

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize
.debug_info,0,3410
.debug_line,0,115
.debug_loc,0,90
[Unmapped],0,40
.debug_abbrev,0,36
.debug_str,0,33
.flash.text,-40,-40

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
.debug_info,0,3303
.debug_line,0,115
.debug_loc,0,101
.debug_abbrev,0,36
[Unmapped],0,36
.debug_str,0,33
.flash.text,-36,-36


@bzbarsky-apple
Copy link
Contributor Author

@bzbarsky-apple bzbarsky-apple merged commit f5d69c2 into project-chip:master Jul 14, 2021
@bzbarsky-apple bzbarsky-apple deleted the acks-are-not-message-sends branch July 14, 2021 20:08
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
…andalone ack. (project-chip#8298)

This state is meant to track app-level sends, and standalone acks are
not app-level.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants