Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Build on Linux (no_progress_logging) (pull_request) #8283

Merged

Conversation

kpschoedel
Copy link
Contributor

Problem

Builds / Build on Linux (no_progress_logging) (pull_request) fails to
build due to a misplaced break.

Change overview

Move it.

Testing

Builds / Build on Linux (no_progress_logging) (pull_request)

#### Problem

`Builds / Build on Linux (no_progress_logging) (pull_request)` fails to
build due to a misplaced `break`.

#### Change overview

Move it.

#### Testing

`Builds / Build on Linux (no_progress_logging) (pull_request)`
@boring-cyborg boring-cyborg bot added the app label Jul 10, 2021
@kpschoedel kpschoedel added the hotfix urgent fix needed, can bypass review label Jul 10, 2021
@pullapprove pullapprove bot added review - pending and removed hotfix urgent fix needed, can bypass review labels Jul 10, 2021
@github-actions
Copy link

Size increase report for "esp32-example-build" from 1fde45f

File Section File VM
chip-temperature-measurement-app.elf .flash.text 60 60
chip-all-clusters-app.elf .flash.text 24 24
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
.flash.text,60,60
[Unmapped],0,-60

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.xt.lit._ZN4chip6System5Mutex6UnlockEv,0,128
.xt.lit._ZN4chip11DeviceLayer8Internal35GenericPlatformManagerImpl_FreeRTOSINS0_19PlatformManagerImplEE10_PostEventEPKNS0_15ChipDeviceEventE,0,80
.xt.prop._ZN4chip11DeviceLayer8Internal26GenericPlatformManagerImplINS0_19PlatformManagerImplEE14_InitChipStackEv,0,40
.flash.text,24,24
.xt.prop._ZN4chip11DeviceLayer8Internal35GenericPlatformManagerImpl_FreeRTOSINS0_19PlatformManagerImplEE14_LockChipStackEv,0,-12
.xt.prop._ZN4chip11DeviceLayer8Internal35GenericPlatformManagerImpl_FreeRTOSINS0_19PlatformManagerImplEE15_StartChipTimerEj,0,-12
.xt.prop._ZN4chip11DeviceLayer8Internal35GenericPlatformManagerImpl_FreeRTOSINS0_19PlatformManagerImplEE16_UnlockChipStackEv,0,-12
[Unmapped],0,-24
.xt.lit._ZN4chip11DeviceLayer8Internal35GenericPlatformManagerImpl_FreeRTOSINS0_19PlatformManagerImplEE14_LockChipStackEv,0,-48
.xt.lit._ZN4chip11DeviceLayer8Internal35GenericPlatformManagerImpl_FreeRTOSINS0_19PlatformManagerImplEE15_StartChipTimerEj,0,-48
.xt.lit._ZN4chip11DeviceLayer8Internal35GenericPlatformManagerImpl_FreeRTOSINS0_19PlatformManagerImplEE16_UnlockChipStackEv,0,-48
.xt.prop._ZN4chip6System5Mutex6UnlockEv,0,-108


@kpschoedel kpschoedel added the hotfix urgent fix needed, can bypass review label Jul 10, 2021
@bzbarsky-apple bzbarsky-apple merged commit 0e19e0d into project-chip:master Jul 10, 2021
@kpschoedel kpschoedel deleted the subscribe-request-hotfix branch July 13, 2021 15:51
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
…#8283)

#### Problem

`Builds / Build on Linux (no_progress_logging) (pull_request)` fails to
build due to a misplaced `break`.

#### Change overview

Move it.

#### Testing

`Builds / Build on Linux (no_progress_logging) (pull_request)`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app hotfix urgent fix needed, can bypass review review - pending
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants