-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Lock app example for infineon P6 board #8268
Add Lock app example for infineon P6 board #8268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't review the src/platform things very carefully....
The main question here is what's going on with the third_party repo bits.
9906eeb
to
ed1dfa9
Compare
ed1dfa9
to
b64dba1
Compare
3547693
to
e05308f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Request changes: I believe for build items to be part of the official image, we would wand CHIP developers to be able to validate at least 'this builds' without requiring 3rd party code registration/license agreement/downloads. We would also like to be able to setup CI for our example build targets so they do not break (we are lacking resources right now, but still hoping we can fix or at least run periodically a 'build everything')
For this purpose, all required prerequisites should be accessible at a minimum in the chip-build-vscode. I would start with a PR first that updates the docker images (potentially creating a separate chip-build-infineon image as well for the vscode image to copy from).
e05308f
to
61bb982
Compare
@andy31415, @praveenCY has applied the requested changes. Do you have any additional feedback? Thank you in advance, Ian |
Removing changes requested: a direct download link for the SDK was provided.
I would like to state for the record, that even if we say that vendors are responsible for their platforms, it is still imposes costs on other contributors. Consider Kevin's error handling work and how adding platform code adds more work to that. (I don't think you are saying that, but what I am saying is that we still need to do a decent review of the code - and we really need to work on the code duplication so that badly need platform interface work does not become impossible to execute). We have the technical reviewed flag, we can use that here (I can take that for this one). If nobody can review the 10K lines, the patch must not land. |
76d4034
to
fe3f6ae
Compare
fe3f6ae
to
8d33234
Compare
8d33234
to
ea8e6bb
Compare
/gcbrun |
@msandstedt @saurabhst @LuDuda @Damian-Nordic @jelderton @jepenven-silabs @jmartinez-silabs Please take a look? |
ea8e6bb
to
137fd1f
Compare
Size increase report for "esp32-example-build" from 6a36256
Full report output
|
* Add Lock app example for infineon P6 board * P6 lock app changes addressing review comments * Update Code changes to support new Clock modifications * Rename repo to p6_sdk along with docker vscode changes * Update README.md with dockerfile link for software download * Remove warnings false check for compile * Update script to remove sudo and cleanup folder names * Add all Infineon assets as gitsubmodules * Address review comments cleaning up code * Cleanup code as per final review comments * Address BLE configuration comments
Problem
There is no Support for Infineon P6 board on Matter
Change overview
Adding Support for Infineon CY8CKIT-062S2-43012 board on Matter along with Lock app example
Testing
How was this tested? (at least one bullet point required)
If new unit tests are not added, why not?
Unit tests are not support as of now and will be covered as part of next release update
If new integration tests are not added, why not?
Integration and CI build support will be added as part of next update
If manually tested, what platforms controller and device platforms were manually tested, and how?
CY8CKIT-062S2-43012 + Raspberry Pi4 (chip-device-ctrl)
Detailed steps are added in lock app README.md
Build command
./scripts/examples/gn_p6_example.sh examples/lock-app/p6
P6_Lock_app_logs.txt