-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Window Covering cluster: ZAP configuration updated. #8249
Window Covering cluster: ZAP configuration updated. #8249
Conversation
Size increase report for "esp32-example-build" from 6628298
Full report output
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine, but does all-clusters-app need similar updates?
Thanks @ricardo-casallas, @jmartinez-silabs @bzbarsky-apple just to let you know why i renamed Stop as StopMotion . This was done to avoid conflict with another function with the same name from another cluster. Since Zap namespace is not working nicely/properly yet on all part of the code, here by renaming Stop the handler gonna call Stop from another cluster, you can't detect it because the CI wont catch this error. I was willing to rename this command in the specs. This is not a big deal i will correct in a newer PR |
@jmeg-sfy Do we have a ticket to track this issue in ZAP. There was another error with commands with the same names over different clusters that didn't get generated but that got fixed some time ago. This seems related but we will need to track this issue. |
Yes, @jmeg-sfy please make sure there is an issue filed with a very clear description of the ZAP problem and that @tecimovic and @vivien-apple are aware of it. |
Problem
Window Cluster configuration is outdated.
Change overview
The following attributes where added to examples/window-app/common/window-app.zap:
Testing